tests: canbus: isotp: conformance: fix shadow variables removal #61732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 505c17e. Signed-off-by: Martin Jäger <martin@libre.solar>
Remove shadow variables found by -Wshadow by using the global recv_ctx consistently throughout all the internal test helper functions. Signed-off-by: Martin Jäger <martin@libre.solar>
martinjaeger
requested review from
dcpleung and
henrikbrixandersen
and removed request for
nashif
nashif
approved these changes
Aug 22, 2023
str4t0m
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove shadow variables found by -Wshadow by using the global
recv_ctxconsistently throughout all the internal test helper functions.The fix provided in #61523 did not consider that there is also a
send_ctx, so that the variable naming looked quite inconsistent.