New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for network interface user friendly name #61876
Add support for network interface user friendly name #61876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some minor comments. I think it'd make sense to update the SO_BINDTODEVICE
implementation as well, for now it relies on the device name, but it should use the interface name instead I believe.
8d5029b
to
d17402a
Compare
8c2e894
to
c252d8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
c252d8b
to
5f68c93
Compare
If CONFIG_NET_INTERFACE_NAME is enabled (default is y), then system will automatically set a user friendly name to the network interface like eth0, wlan0 etc. Application can change the interface name if needed. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
Check that we can set and get the network interface name. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
Make sure we use the network interface name (if configured) instead of device name when binding to certain network interface. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
If network interface name support is enabled, print the name when showing network interface data. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
5f68c93
to
bb8ff59
Compare
Increased the max name length to 15 chars. |
If
CONFIG_NET_INTERFACE_NAME
is enabled (default is y), then the system will automatically set a user friendly name to the network interface like eth0, wlan0 etc. Application can change the interface name if needed.This is useful so that applications do not need to try to use the device name for figuring out the desired network interface.