Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for TDK NTCG103JF103FT1 thermistor #62185

Merged

Conversation

maxmclau
Copy link
Contributor

Adds compensation table for NTCG103JF103FT1 thermistor. The compensation table for this thermistor is shared with a few other thermistors like the NTCG163JF103FT1 so maybe it'd make sense to rename it NTCG1x3JF103FT1? Wasn't sure how Zephyr prefers to handle those sorts of naming conventions.

@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors labels Aug 31, 2023
@maxmclau maxmclau force-pushed the ntcg163jf103ft1-support branch 4 times, most recently from 3554696 to f22918c Compare September 1, 2023 15:21
@maxmclau
Copy link
Contributor Author

maxmclau commented Sep 6, 2023

any chance this could be reviewed soon? I'm also up to wait until #60682 is merged if that's easier

@MaureenHelm
Copy link
Member

any chance this could be reviewed soon? I'm also up to wait until #60682 is merged if that's easier

#60682 has been merged. Please rebase

Adds compensation table and bindings for NTCG103JF103FT1 thermistor

Signed-off-by: Maxmillion McLaughlin <github@maxmclau.com>
@maxmclau
Copy link
Contributor Author

maxmclau commented Sep 22, 2023

any chance this could be reviewed soon? I'm also up to wait until #60682 is merged if that's easier

#60682 has been merged. Please rebase

Rebased - should be good for review

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Nov 22, 2023
@github-actions github-actions bot closed this Dec 7, 2023
@MaureenHelm
Copy link
Member

@teburd @yperess Can you take a look at this? It's a pretty simple change that fell through the cracks

@MaureenHelm MaureenHelm reopened this Dec 7, 2023
@MaureenHelm MaureenHelm removed the Stale label Dec 7, 2023
@fabiobaltieri fabiobaltieri merged commit 8ab1c75 into zephyrproject-rtos:main Dec 8, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants