samples: webusb: Host webusb demo app directly on zephyr doc #62420
Conversation
finikorg
force-pushed
the
webusp_app
branch
2 times, most recently
from
1b24599
to
73b3d83
Compare
There was a problem hiding this comment.
That's awesome - thanks!
Consider my only comment as non-blocking.
Note: the demo page is effectively <html> within <html> which is probably a bit hackish and not really w3c compliant, but I'd say the tradeoff is worthwhile (plus, people have the link to the raw source if needed).
finikorg
changed the title
finikorg
requested review from
nashif,
jfischer-no and
carlescufi
as code owners
zephyrbot
added
area: USB
There was a problem hiding this comment.
While I appreciate that you kept commit authorship set to myself for the first commit, it doesn't look right as it probably doesn't compile as-is. Maybe just squash the first two? Or, probably better, re-order with a first commit that moves "your" code to clearly show it's you that's contributing this, and then do the rest with co-authored-by in a second commit.
Thanks again!
Copy file index.html from the external repository finikorg/webusb-sample. Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Include demo.rst to the webusb sample documentation. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Include only README.rst to docs, skipping helpers included with :doc: directive. Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Update webusb README with recent changes after index.html was moved to sample from the external repository. Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
samples/subsys/usb/webusb/index.html
Outdated
| @@ -0,0 +1,125 @@ | |||
| <html> | |||
There was a problem hiding this comment.
Just realized it would probably make sense to run this file through a code formatter
There was a problem hiding this comment.
BTW, you can make commit and push it to this branch after my commits.
kartben
dismissed stale reviews from jfischer-no and tmon-nordic
via
417a91c
Running the HTML code through W3C Validator revealed several issues with the markup that this commit fixes. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
kartben
dismissed
their stale review
Didn't realize I was blocking this, sorry. Dismissing my own review as I am not in a position to +1 now that I've added commits to this. Luckily it now has enough approvals though :)
Move artifacts from private repository to zephyr docs.
Fixes: finikorg/webusb-sample#3