Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONFIG_MCUBOOT_BOOTLOADER_NO_DOWNGRADE to MCUboot module #63053

Merged

Conversation

de-nordic
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be good for this is if an option was added to sysbuild so that it could enable the option in MCUboot automatically

modules/Kconfig.mcuboot Outdated Show resolved Hide resolved
@@ -353,6 +353,11 @@ HALs
MCUboot
*******

* Added :kconfig:option:`CONFIG_MCUBOOT_BOOTLOADER_MODE_WITH_DOWNGRADE_PREVENTION`
that allows to inform application that the on-board MCUboot has been configured
with download prevention enabled. This option is automatically selected for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*downgrade

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@de-nordic de-nordic force-pushed the mcumgr-downgrade-prevention branch 2 times, most recently from 69c2928 to 8ae6e69 Compare September 25, 2023 14:12
bool
help
Selected mode supports downgrade prevention, where you can not switch to
Selected mode supports downgrade prevention, where you cannot switch to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -353,6 +353,11 @@ HALs
MCUboot
*******

* Added :kconfig:option:`CONFIG_MCUBOOT_BOOTLOADER_MODE_WITH_DOWNGRADE_PREVENTION`
that allows to inform application that the on-board MCUboot has been configured
with downgrade prevention enabled. This option is automatically selected for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double space

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


endchoice # MCUBOOT_BOOTLOADER_MODE

config MCUBOOT_BOOTLOADER_MODE_SUPPORTS_DOWNGRADE_PREVENTION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MCUBOOT_BOOTLOADER_MODE_HAS_NO_DOWNGRADE

an application with lower version than the currently running application.

if MCUBOOT_BOOTLOADER_MODE_SUPPORTS_DOWNGRADE_PREVENTION
config MCUBOOT_BOOTLOADER_MODE_WITH_DOWNGRADE_PREVENTION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MCUBOOT_BOOTLOADER_NO_DOWNGRADE

Add the MCUBOOT_BOOTLOADER_NO_DOWNGRADE Kconfig option that allows,
when paired with MCUboot mode Kconfig, to indicate that the MCUboot
has been configured with downgrade prevention, which means that only
application with version higher than running can be swapped on next boot.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Adds note on addition of
MCUBOOT_BOOTLOADER_MODE_WITH_DOWNGRADE_PREVENTION
to MCUboot Kconfig module.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
@carlescufi carlescufi merged commit a431072 into zephyrproject-rtos:main Sep 26, 2023
18 checks passed
@kartben kartben changed the title Add CONFIG_MCUBOOT_BOOTLOADER_MODE_WITH_DOWNGRADE_PREVENTION to MCUboot module Add CONFIG_MCUBOOT_BOOTLOADER_NO_DOWNGRADE to MCUboot module Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: MCUBoot Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants