Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neural_net: remove unused experimental API #63300

Merged
merged 1 commit into from Sep 30, 2023
Merged

neural_net: remove unused experimental API #63300

merged 1 commit into from Sep 30, 2023

Conversation

nashif
Copy link
Member

@nashif nashif commented Sep 29, 2023

Experimental API is not being used anymore, remove it.

Signed-off-by: Anas Nashif anas.nashif@intel.com

@kartben kartben self-requested a review September 29, 2023 12:16
kartben
kartben requested changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the housekeeping effort!

  • Need to remove from api/overview as well
  • Nit: you have a typo in the commit message
  • I know we don't have to (or do we?) but this would probably be worth adding an entry in the release notes already.

@nashif
neural_net: remove unused experimental API
f1a32ec 
Experimental API is not being used anymore, remove it.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif nashif requested a review from kartben September 29, 2023 12:49
@kartben kartben changed the title nenural_net: remove unused experimental API neural_net: remove unused experimental API Sep 29, 2023
kartben
kartben approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 so that this gets a chance to be part of rc1 but would be nice to make sure it's mentioned in the release notes.

@nashif nashif merged commit 34e1622 into zephyrproject-rtos:main Sep 30, 2023
26 checks passed
@nashif nashif deleted the topic/remov_neural branch September 30, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@alexanderwachter alexanderwachter alexanderwachter approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi

@galak galak Awaiting requested review from galak

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@cfriedt cfriedt Awaiting requested review from cfriedt

@stephanosio stephanosio Awaiting requested review from stephanosio

Assignees
No one assigned
Labels
area: C++ area: Documentation area: Neural Networks area: Process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nashif @kartben @alexanderwachter @zephyrbot