boards: arm: add support for WeAct STM32G431 Core #63889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysan
requested review from
nashif,
sambhurst,
MaureenHelm and
galak
as code owners
zephyrbot
requested review from
57300,
jeremybettis,
keith-zephyr,
mbolivar-ampere,
nordicjm and
tejlmand
andysan
force-pushed
the
weact_stm32g431_core
branch
2 times, most recently
from
7c9da3d
to
e3745bd
Compare
nordicjm
reviewed
Oct 13, 2023
tejlmand
reviewed
Oct 13, 2023
andysan
force-pushed
the
weact_stm32g431_core
branch
2 times, most recently
from
0282e5e
to
abe2ab7
Compare
|
Given that PD support requires some board modifications, would it be a good idea to represent the PD-enabled board as a variant board? I.e., create a Edit: Looking at the documentation, this might not be possible without abusing the revision system. |
andysan
force-pushed
the
weact_stm32g431_core
branch
from
abe2ab7
to
024df1b
Compare
mbolivar-ampere
requested changes
Oct 13, 2023
andysan
force-pushed
the
weact_stm32g431_core
branch
from
024df1b
to
9d77562
Compare
mbolivar-ampere
previously approved these changes
Oct 26, 2023
andysan
force-pushed
the
weact_stm32g431_core
branch
from
9d77562
to
e90db07
Compare
erwango
requested changes
Oct 26, 2023
andysan
force-pushed
the
weact_stm32g431_core
branch
2 times, most recently
from
7eb2801
to
88e1239
Compare
kartben
requested changes
Oct 27, 2023
andysan
force-pushed
the
weact_stm32g431_core
branch
from
88e1239
to
b6ddb8b
Compare
Add support for the WeAct Studio STM32G431 Core Board. Tested with: - `samples/basic/blinky` - `samples/basic/button` Flashed samples using dfu-util. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk>
Add support for the WeAct Studio STM32G431 Core board. Note that this board does not support USB-C PD in its default configuration. See the board documentation for the necessary hardware reconfiguration. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk>
andysan
force-pushed
the
weact_stm32g431_core
branch
from
b6ddb8b
to
c334ba5
Compare
erwango
approved these changes
Nov 2, 2023
|
Ping @kartben. I should have fixed the issues you pointed out. |
|
Hi @kartben, it's been 3 weeks. Any chance you could have a look at the updated changeset and see if it addressed your comments? |
kartben
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the WeAct STM32G431 Core board. This is a low-cost STM32G431 board with a USB-C connector. The board supports USB-C PD if the right solder bridges are modified correctly.
This PR depends on #63886.Note to reviewers: Please pay close attention to the clock configuration. I don't have a lot of experience with this particular corner of STM32 MCUs. The DTS file configures the MCU to use the HSE to drive the USB subsystem instead of the HSI48 clock unlike many of the other boards. My understanding is that this is the recommended way to drive the USB block since it provides a more stable clock source.
Testing: Bard has been tested with the USB-C PD example which works as expected and prints its log on the attached UART. Some of the other basic examples have also been tested to ensure that the user button and LED are both mapped correctly.
Update: