drivers: adc: ltc2451: Add ltc2451 driver #64390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: ADI
ethan-duckett-brill
force-pushed
the
add_ltc2451_driver
branch
from
f0a0587
to
5d87b5a
Compare
martinjaeger
requested changes
Nov 7, 2023
MaureenHelm
requested changes
Nov 7, 2023
ethan-duckett-brill
force-pushed
the
add_ltc2451_driver
branch
from
87ec3f0
to
6620097
Compare
martinjaeger
requested changes
Nov 8, 2023
ethan-duckett-brill
force-pushed
the
add_ltc2451_driver
branch
4 times, most recently
from
0da7d8d
to
a6ccdef
Compare
martinjaeger
requested changes
Nov 8, 2023
There was a problem hiding this comment.
The driver needs to be added to the build_all unit tests by adding a devicetree node to tests/drivers/build_all/adc/app.overlay. See the recently merged #64592 as an example.
ethan-duckett-brill
force-pushed
the
add_ltc2451_driver
branch
2 times, most recently
from
7c3e540
to
13fc81e
Compare
MaureenHelm
requested changes
Nov 8, 2023
ethan-duckett-brill
force-pushed
the
add_ltc2451_driver
branch
from
13fc81e
to
084f702
Compare
martinjaeger
previously approved these changes
Nov 8, 2023
ethan-duckett-brill
force-pushed
the
add_ltc2451_driver
branch
from
084f702
to
e950b48
Compare
bbilas
reviewed
Nov 8, 2023
bbilas
reviewed
Nov 8, 2023
bbilas
reviewed
Nov 8, 2023
bbilas
reviewed
Nov 8, 2023
bbilas
reviewed
Nov 8, 2023
bbilas
reviewed
Nov 8, 2023
bbilas
reviewed
Nov 8, 2023
ethan-duckett-brill
force-pushed
the
add_ltc2451_driver
branch
from
e950b48
to
3fd0868
Compare
ethan-duckett-brill
requested review from
MaureenHelm,
martinjaeger and
bbilas
bbilas
reviewed
Nov 9, 2023
ethan-duckett-brill
force-pushed
the
add_ltc2451_driver
branch
from
3fd0868
to
d3b8888
Compare
bbilas
reviewed
Nov 9, 2023
Adds support for the Linear Technologies LTC2451 ADC. Signed-off-by: Ethan Duckett <ethan.duckett@brillpower.com>
ethan-duckett-brill
force-pushed
the
add_ltc2451_driver
branch
from
d3b8888
to
469a795
Compare
MaureenHelm
approved these changes
Nov 9, 2023
bbilas
approved these changes
Nov 9, 2023
|
Thank you for the reviews guys, hopefully once this pipeline has finished we should be good to go! |
martinjaeger
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the Linear Technologies LTC2451 ADC.