Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "sanitycheck: Default to using Ninja" #6479

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

nashif
Copy link
Member

@nashif nashif commented Mar 6, 2018

This reverts commit 0e6689d.

Parallel builds are broken due to a mix of Make/Ninja and the job server
not being operational.

See ninja-build/ninja#1139

Signed-off-by: Anas Nashif anas.nashif@intel.com

This reverts commit 0e6689d.

Parallel builds are broken due to a mix of Make/Ninja and the job server
not being operational.

See ninja-build/ninja#1139

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif nashif requested a review from andrewboie as a code owner March 6, 2018 13:39
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@8c0c4be). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #6479   +/-   ##
========================================
  Coverage          ?   53.2%           
========================================
  Files             ?     436           
  Lines             ?   41353           
  Branches          ?    7937           
========================================
  Hits              ?   22001           
  Misses            ?   16128           
  Partials          ?    3224

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c0c4be...bc61319. Read the comment docs.

Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do a smarter revert, to leave the -M option, and just change the default?

@nashif nashif merged commit 25f6ab6 into zephyrproject-rtos:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants