Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: up_squared_pro_7000: Add new board definition #65019

Merged
merged 6 commits into from Nov 14, 2023

Conversation

finikorg
Copy link
Collaborator

@finikorg finikorg commented Nov 9, 2023

Add board definition for UP Squared Pro 7000 (https://up-board.org/up-squared-pro-7000/). The board is powered by Intel Alder Lake N (N-series Intel Platform).

@finikorg
Copy link
Collaborator Author

finikorg commented Nov 9, 2023

@kartben Do you know, can this work 3ec24fa

@kartben
Copy link
Collaborator

kartben commented Nov 9, 2023

@kartben Do you know, can this work 3ec24fa

I think maybe something like the following would be better (didn't actually test the pattern btw)? renaming common to _common to better materialize that it's "internal" stuff?

[!_]*/**/*

jhedberg
jhedberg previously approved these changes Nov 10, 2023
@finikorg
Copy link
Collaborator Author

finikorg commented Nov 10, 2023

Added commit ad1a734 to fix broken CI, also created PR #65052

@finikorg finikorg changed the title boards: up7000: Add UP 7000 board definition boards: up_squared_pro_7000: Add new board definition Nov 10, 2023
jhedberg
jhedberg previously approved these changes Nov 11, 2023
@jhedberg
Copy link
Member

@finikorg I guess we can remove the DNM label now?

Add board definition for UP Squared Pro 7000.
The board is powered by Intel Alder Lake N (N-series Intel Platform).

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Add documentation for UP Squared Pro 7000 board.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Modify toctree glob to exclude common directory which keeps rst
helpers. This allows to include several boards documentation from the
common board directory.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Add AAEON Technology Inc prefix.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Correct vendor name for up_squared board, the same as for UP 7000
board.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Add up_squared_pro_7000 overlay for watchdog test and sample.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
@finikorg
Copy link
Collaborator Author

@finikorg I guess we can remove the DNM label now?

Added commit to fix CI: e3efcdb

@finikorg finikorg removed the DNM This PR should not be merged (Do Not Merge) label Nov 11, 2023

Programming and Debugging
*************************
Use the following procedures for booting an image for an UP SQUARED PRO 7000 board.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know if that matters on doc generation, but an empty line before might be missing

Copy link
Collaborator Author

@finikorg finikorg Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OK, https://builds.zephyrproject.io/zephyr/pr/65019/docs/boards/x86/intel_adl/doc/up_squared_pro_7000.html
I'll check probably add empty line like in other places.


A Zephyr EFI image file named :file:`zephyr.efi` is automatically
created in the build directory after the application is built.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a console wiring paragraph would be nice (CN14, CN15, CN16: which one needs to be used for the serial output?)

@carlescufi carlescufi merged commit a3ff8d5 into zephyrproject-rtos:main Nov 14, 2023
24 of 27 checks passed
@finikorg finikorg deleted the x86 branch November 14, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Samples Samples area: Time Aware GPIO area: Watchdog Watchdog platform: X86 x86 and x86-64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants