RFC: Breaking API change: drivers: can: remove CAN_FILTER_FDF flag #65108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikbrixandersen
added
RFC
henrikbrixandersen
changed the title
henrikbrixandersen
force-pushed
the
can_remove_fdf_filtering
branch
2 times, most recently
from
9b02aa1
to
29668a5
Compare
|
Rebased on |
henrikbrixandersen
force-pushed
the
can_remove_fdf_filtering
branch
from
29668a5
to
6b4d097
Compare
henrikbrixandersen
force-pushed
the
can_remove_fdf_filtering
branch
from
6b4d097
to
f3b17b4
Compare
|
Rebased on |
henrikbrixandersen
force-pushed
the
can_remove_fdf_filtering
branch
2 times, most recently
from
cb0c663
to
6de5bbc
Compare
Remove the CAN_FILTER_FDF flag for filtering on classic CAN/CAN FD frames as it is not supported natively by any known CAN controller. Applications can still filter on classic CAN/CAN FD frames in their receive callback functions as needed. Fixes: zephyrproject-rtos#64554 Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
henrikbrixandersen
force-pushed
the
can_remove_fdf_filtering
branch
from
6de5bbc
to
d10227d
Compare
|
Rebased to resolve merge conflict after 9eb0a55. |
henrikbrixandersen
requested review from
mmahadevan108 and
dleach02
as code owners
zephyrbot
added
area: Networking
platform: NXP
zephyrbot
requested review from
aescolar,
alexanderwachter,
danieldegrasse,
decsny,
DerekSnell,
EmilioCBen,
karstenkoenig,
kartben,
martinjaeger,
MaureenHelm,
str4t0m and
yvanderv
henrikbrixandersen
changed the title
martinjaeger
requested changes
Jan 18, 2024
Add a note about the removal of the CAN_FILTER_FDF flag from the CAN controller driver API. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
henrikbrixandersen
force-pushed
the
can_remove_fdf_filtering
branch
from
d10227d
to
8493f95
Compare
martinjaeger
approved these changes
Jan 18, 2024
manuargue
approved these changes
Jan 19, 2024
congnguyenhuu
added a commit
to nxp-zephyr/zephyr
that referenced
this pull request
Jan 23, 2024
…-RX_FIFO This is driver limitation after removing CAN_FILTER_FDF flag zephyrproject-rtos#65108. CANXL driver need to know CAN_FILTER_FDF for configuring Rx filter so that it receives CAN classic or CAN FD frames when using non RX_FIFO. So need to wrap the CAN_MODE_FD capability that just supports for RX_FIFO. Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
congnguyenhuu
added a commit
to nxp-zephyr/zephyr
that referenced
this pull request
Jan 23, 2024
…FIFO This is driver limitation after removing CAN_FILTER_FDF flag zephyrproject-rtos#65108. CANXL driver need to know CAN_FILTER_FDF for configuring Rx filter so that it receives CAN classic or CAN FD frames when using non RX_FIFO. So need to wrap the CAN_MODE_FD capability that just supports for RX_FIFO. Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
congnguyenhuu
added a commit
to nxp-zephyr/zephyr
that referenced
this pull request
Jan 24, 2024
This is driver limitation after removing CAN_FILTER_FDF flag zephyrproject-rtos#65108. CANXL driver need to know CAN_FILTER_FDF for configuring Rx filter so that it receives CAN classic or CAN FD frames when using non RX_FIFO. So update driver that just supports CAN classic for non RX_FIFO. Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
congnguyenhuu
added a commit
to nxp-zephyr/zephyr
that referenced
this pull request
Jan 24, 2024
This is driver limitation after removing CAN_FILTER_FDF flag zephyrproject-rtos#65108. CANXL driver need to know CAN_FILTER_FDF for configuring Rx filter so that it receives CAN classic or CAN FD frames when using non RX_FIFO. So update driver that just supports CAN classic for non RX_FIFO. Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
fabiobaltieri
pushed a commit
that referenced
this pull request
Jan 24, 2024
This is driver limitation after removing CAN_FILTER_FDF flag #65108. CANXL driver need to know CAN_FILTER_FDF for configuring Rx filter so that it receives CAN classic or CAN FD frames when using non RX_FIFO. So update driver that just supports CAN classic for non RX_FIFO. Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the CAN_FILTER_FDF flag for filtering on classic CAN/CAN FD frames as it is not supported natively by any known CAN controller.
Applications can still filter on classic CAN/CAN FD frames in their receive callback functions as needed.
Fixes: #64554
RFC issue: #65109
Note: This currently includes the changes from #65058 in order to remove the mix of software and hardware filtering in the Bosch M_CAN backend completely, which is what led to #64554.