Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: gnss: Fix nano parameter not being checked in __ASSERT #65201

Merged
merged 1 commit into from Nov 15, 2023

Conversation

michael-whg
Copy link
Contributor

          str is being checked instead of nano

Originally posted by @michael-whg in #61073 (comment)

@zephyrbot zephyrbot added area: GNSS Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels Nov 15, 2023
Copy link

Hello @michael-whg, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@michael-whg michael-whg changed the title GNSS driver: Fix nano parameter not being checked in __ASSET driver: gnss: Fix nano parameter not being checked in __ASSET Nov 15, 2023
@michael-whg michael-whg changed the title driver: gnss: Fix nano parameter not being checked in __ASSET drivers: gnss: Fix nano parameter not being checked in __ASSET Nov 15, 2023
Copy link
Collaborator

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted some potential ROM size savings - out of the scope of this PR though, feel free to push another commit for this

Comment on lines 28 to +29
__ASSERT(str != NULL, "str argument must be provided");
__ASSERT(str != NULL, "nano argument must be provided");
__ASSERT(nano != NULL, "nano argument must be provided");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__ASSERT(str != NULL, "str argument must be provided");
__ASSERT(str != NULL, "nano argument must be provided");
__ASSERT(nano != NULL, "nano argument must be provided");
__ASSERT(str != NULL, "%s argument must be provided", "str");
__ASSERT(nano != NULL, "%s argument must be provided", "nano");

@ycsin ycsin changed the title drivers: gnss: Fix nano parameter not being checked in __ASSET drivers: gnss: Fix nano parameter not being checked in __ASSERT Nov 15, 2023
@ycsin
Copy link
Collaborator

ycsin commented Nov 15, 2023

@michael-whg please fix the signed-off

str is being checking the __ASSERT where nano should be being checked

Signed-off-by: MD Peace <michael@whgsolutions.team>
@fabiobaltieri
Copy link
Member

@michael-whg thanks for following up on this

@fabiobaltieri fabiobaltieri merged commit 5fee1b1 into zephyrproject-rtos:main Nov 15, 2023
16 checks passed
Copy link

Hi @michael-whg!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: GNSS Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants