New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: gnss: Fix nano parameter not being checked in __ASSERT #65201
Conversation
Hello @michael-whg, and thank you very much for your first pull request to the Zephyr project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted some potential ROM size savings - out of the scope of this PR though, feel free to push another commit for this
__ASSERT(str != NULL, "str argument must be provided"); | ||
__ASSERT(str != NULL, "nano argument must be provided"); | ||
__ASSERT(nano != NULL, "nano argument must be provided"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__ASSERT(str != NULL, "str argument must be provided"); | |
__ASSERT(str != NULL, "nano argument must be provided"); | |
__ASSERT(nano != NULL, "nano argument must be provided"); | |
__ASSERT(str != NULL, "%s argument must be provided", "str"); | |
__ASSERT(nano != NULL, "%s argument must be provided", "nano"); |
@michael-whg please fix the signed-off |
str is being checking the __ASSERT where nano should be being checked Signed-off-by: MD Peace <michael@whgsolutions.team>
@michael-whg thanks for following up on this |
Hi @michael-whg! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
Originally posted by @michael-whg in #61073 (comment)