Bluetooth: Mesh: Fix Coverity reports #65402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This suppresses warning from Coverity. Coverity-CID: 330638 Fixes zephyrproject-rtos#65330 Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
Coverity-CID: 323094 Fixes zephyrproject-rtos#65366 Coverity-CID: 323081 Fixes zephyrproject-rtos#65370 Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
The Private Beacon Client API requires a response argument to allow to call the API in the asynchronous manner (zephyrproject-rtos#56426). Because the removal of the EXPERIMENTAL tag for this API was not released yet, it should be OK to change this API. The EXPERIMENTAL tag has been removed here: zephyrproject-rtos#64866 Coverity-CID: 330039 Coverity-CID: 330029 Coverity-CID: 329977 Fixes zephyrproject-rtos#65336 Fixes zephyrproject-rtos#65338 Fixes zephyrproject-rtos#65354 Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
zephyrbot
requested review from
akredalen,
alxelax,
Andrewpini,
asbjornsabo,
hermabe,
jhedberg,
LingaoM,
sjanc,
Thalley and
Vudentz
Fix potential integer overflow by casting one of operands to int64_t. Coverity-CID: 329961 Fixes zephyrproject-rtos#65356 Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
|
Added missed Coverity report |
alxelax
approved these changes
Nov 17, 2023
LingaoM
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes has been done in this PR:
Ignore return value of
settings_delete.Coverity-CID: 330638
Fixes #65330
Check return value of
bt_conn_get_info.Coverity-CID: 323094
Fixes #65366
Coverity-CID: 323081
Fixes #65370
Fix async behavior of Private Beacon Client API.
The Private Beacon Client API requires a response argument to allow to call the API in the asynchronous manner (#56426).
Because the removal of the EXPERIMENTAL tag for this API was not released yet, it should be OK to change this API. The EXPERIMENTAL tag has been removed here: #64866
Coverity-CID: 330039
Coverity-CID: 330029
Coverity-CID: 329977
Fixes #65336
Fixes #65338
Fixes #65354
Fix integer overflow
Fix potential integer overflow by casting one of operands to int64_t.
Coverity-CID: 329961
Fixes #65356