Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: arm: Add support for ARM FK7B0M1-VBT6 V1.0 board #65441

Merged

Conversation

CharlesDias
Copy link
Contributor

The following features have been tested and confirmed to work on the hardware:

  • LED
  • Button
  • UART
  • Flashing the binary via west flash command

@CharlesDias CharlesDias force-pushed the new_board_arm_fk7b0m1-vbt6 branch 8 times, most recently from 9f11541 to 9f5f202 Compare November 19, 2023 18:31
@CharlesDias CharlesDias changed the title Add support for AMR FK7B0M1-VBT6 V1.0 board boards: arm: Add support for AMR FK7B0M1-VBT6 V1.0 board Nov 19, 2023
@kartben kartben self-requested a review November 19, 2023 19:57
boards/arm/fk7b0m1_vbt6/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/arm/fk7b0m1_vbt6/board.cmake Outdated Show resolved Hide resolved
boards/arm/fk7b0m1_vbt6/doc/index.rst Outdated Show resolved Hide resolved
boards/arm/fk7b0m1_vbt6/doc/index.rst Outdated Show resolved Hide resolved
boards/arm/fk7b0m1_vbt6/fk7b0m1_vbt6.dts Show resolved Hide resolved
boards/arm/fk7b0m1_vbt6/doc/index.rst Outdated Show resolved Hide resolved
@zephyrbot zephyrbot added the area: Devicetree Binding PR modifies or adds a Device Tree binding label Nov 20, 2023
@zephyrbot zephyrbot requested a review from galak November 20, 2023 17:05
@CharlesDias
Copy link
Contributor Author

CharlesDias commented Dec 2, 2023

Hi @kartben and @galak. Any other changes?

Thanks.

Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation looks good, thanks! A few extra comments on my side + you should also please squash the documentation commit with the one introducing the board, as new boards are typically added as just one commit


include(${ZEPHYR_BASE}/boards/common/openocd.board.cmake)
include(${ZEPHYR_BASE}/boards/common/stm32cubeprogrammer.board.cmake)
include(${ZEPHYR_BASE}/boards/common/jlink.board.cmake)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a newline at the end of the file (not sure why CI doesn't catch this)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Let me know if any other modification is needed.


FK7B0M1-VBT6 (Credit: FANKE Technology Co., Ltd)


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you have extra blank lines here and there that would be nice to remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

erwango
erwango previously approved these changes Dec 19, 2023

&clk_hse {
clock-frequency = <DT_FREQ_M(25)>;
status = "okay";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be checked on schematics : if External 25MHz crystal oscillator. should the hse-bypass be set ?

Copy link
Collaborator

@FRASTM FRASTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else LGTM

FRASTM
FRASTM previously approved these changes Dec 20, 2023
@CharlesDias CharlesDias changed the title boards: arm: Add support for AMR FK7B0M1-VBT6 V1.0 board boards: arm: Add support for ARM FK7B0M1-VBT6 V1.0 board Dec 22, 2023
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing my earlier comments, just spotted a couple extra (and minor) issues. Thanks!

boards/arm/fk7b0m1_vbt6/doc/index.rst Outdated Show resolved Hide resolved
boards/arm/fk7b0m1_vbt6/support/openocd.cfg Outdated Show resolved Hide resolved
Adds the device trees, Kconfig, and documentation files.

The following features have been confirmed working on hardware:
* LED
* Button
* UART

Signed-off-by: Charles Dias <charlesdias.cd@outlook.com>
Add vendor prefix fanke FANKE Technology Co., Ltd.

Signed-off-by: Charles Dias <charlesdias.cd@outlook.com>
@CharlesDias CharlesDias dismissed stale reviews from FRASTM and erwango via 51db4ca January 3, 2024 20:48
@fabiobaltieri fabiobaltieri assigned erwango and unassigned galak Jan 12, 2024
@fabiobaltieri fabiobaltieri merged commit 8b96814 into zephyrproject-rtos:main Jan 12, 2024
19 checks passed
@CharlesDias CharlesDias deleted the new_board_arm_fk7b0m1-vbt6 branch February 21, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Boards area: Devicetree Binding PR modifies or adds a Device Tree binding platform: STM32 ST Micro STM32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants