samples: lwm2m: Add support for Connection Manager #65464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlubos
reviewed
Nov 20, 2023
| } | ||
| } | ||
|
|
||
| static int connect(void) |
There was a problem hiding this comment.
Please rename the function, not to be confused with POSIX connect().
| LOG_INF("Connecting to network"); | ||
|
|
||
| ret = conn_mgr_if_connect(net_if_get_default()); | ||
| if (ret) { |
There was a problem hiding this comment.
What if we deal with an interface, that does not require connectivity? There will be no binding defined, and the function will fail. IMO, if we want to support manual connection in the sample, errors should be silently ignored.
Using Connection Manager, it's easy to run lwm2m sample on devices supporting different connectivity technologies (for example, Wi-Fi and LTE). Signed-off-by: Juha Ylinen <juha.ylinen@nordicsemi.no>
juhaylinen
force-pushed
the
lwm2m_conn_mngr
branch
from
744fad0
to
0f13f91
Compare
|
@rlubos I made the requested changes. Please re-check |
rlubos
approved these changes
Nov 24, 2023
SeppoTakalo
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Connection Manager, it's easy to run lwm2m sample on devices supporting different connectivity technologies (for example, Wi-Fi and LTE).