Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: serial: ra: Add support interrupt-driven mode #65775

Merged
merged 6 commits into from Jan 2, 2024

Conversation

soburi
Copy link
Member

@soburi soburi commented Nov 26, 2023

Added support interrupt-driven mode for Renesas RA series UART.

And fix also minor naming issues.

@soburi soburi changed the title Ra uart intr drivers: serial: ra: Add support interrupt-driven mode Nov 26, 2023
@soburi soburi added DNM This PR should not be merged (Do Not Merge) platform: Renesas RA Renesas Electronics Corporation, RA labels Nov 26, 2023
DEVICE_MMIO_MAP() is an unnecessary process, so delete it.

I created uart_ra.c based on uart_rcar.c, but
I forgot to correct the name. I fixed it.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
@soburi soburi force-pushed the ra_uart_intr branch 5 times, most recently from fa88c71 to afa18ad Compare December 23, 2023 16:00
@soburi soburi marked this pull request as ready for review December 23, 2023 23:17
@zephyrbot zephyrbot added area: Interrupt Controller area: UART Universal Asynchronous Receiver-Transmitter labels Dec 23, 2023
@soburi soburi removed the DNM This PR should not be merged (Do Not Merge) label Dec 23, 2023
dcpleung
dcpleung previously approved these changes Dec 27, 2023
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually have a couple comments, sorry clicked approval too early did not realize there were few commits, just nitpicks though :-)

drivers/serial/uart_ra.c Outdated Show resolved Hide resolved
drivers/serial/uart_ra.c Outdated Show resolved Hide resolved
Adding `ra_icu_irq_disconnect_dynamic()` corresponds with
`ra_icu_irq_connect_dynamic()`.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
Don't execute `irq_enable` in process of the `ra_icu_irq_connect_dynamic`.

The caller of `ra_icu_irq_connect_dynamic` is only `gpio_ra_pin_configure`
at this time. `gpio_ra_pin_configure` calls `irq_enable` just after called
`ra_icu_irq_connect_dynamic`.
So removing 'irq_enable' from 'ra_icu_irq_connect_dynamic' has no effect
on behavior.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
Add support interrupt driven mode for Renesas RA UART driver.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
- Corrected indentation with clang-format

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
- Corrected indentation with clang-format

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
@soburi soburi requested a review from dcpleung December 31, 2023 00:07
@fabiobaltieri fabiobaltieri merged commit 89982b7 into zephyrproject-rtos:main Jan 2, 2024
19 checks passed
@soburi soburi deleted the ra_uart_intr branch January 3, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: GPIO area: Interrupt Controller area: UART Universal Asynchronous Receiver-Transmitter platform: Renesas RA Renesas Electronics Corporation, RA platforms: Renesas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants