New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: serial: ra: Add support interrupt-driven mode #65775
Merged
Merged
+399
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soburi
changed the title
Ra uart intr
drivers: serial: ra: Add support interrupt-driven mode
Nov 26, 2023
soburi
added
DNM
This PR should not be merged (Do Not Merge)
platform: Renesas RA
Renesas Electronics Corporation, RA
labels
Nov 26, 2023
DEVICE_MMIO_MAP() is an unnecessary process, so delete it. I created uart_ra.c based on uart_rcar.c, but I forgot to correct the name. I fixed it. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
soburi
force-pushed
the
ra_uart_intr
branch
5 times, most recently
from
December 23, 2023 16:00
fa88c71
to
afa18ad
Compare
zephyrbot
added
area: Interrupt Controller
area: UART
Universal Asynchronous Receiver-Transmitter
labels
Dec 23, 2023
dcpleung
previously approved these changes
Dec 27, 2023
fabiobaltieri
approved these changes
Dec 28, 2023
fabiobaltieri
requested changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually have a couple comments, sorry clicked approval too early did not realize there were few commits, just nitpicks though :-)
Adding `ra_icu_irq_disconnect_dynamic()` corresponds with `ra_icu_irq_connect_dynamic()`. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
Don't execute `irq_enable` in process of the `ra_icu_irq_connect_dynamic`. The caller of `ra_icu_irq_connect_dynamic` is only `gpio_ra_pin_configure` at this time. `gpio_ra_pin_configure` calls `irq_enable` just after called `ra_icu_irq_connect_dynamic`. So removing 'irq_enable' from 'ra_icu_irq_connect_dynamic' has no effect on behavior. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
Add support interrupt driven mode for Renesas RA UART driver. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
- Corrected indentation with clang-format Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
- Corrected indentation with clang-format Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
fabiobaltieri
approved these changes
Dec 30, 2023
dcpleung
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: GPIO
area: Interrupt Controller
area: UART
Universal Asynchronous Receiver-Transmitter
platform: Renesas RA
Renesas Electronics Corporation, RA
platforms: Renesas
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support interrupt-driven mode for Renesas RA series UART.
And fix also minor naming issues.