Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement daisy chaining for BD8LB600FS #65982

Merged

Conversation

benediktibk
Copy link
Collaborator

@benediktibk benediktibk commented Nov 30, 2023

This implements the daisy chain feature of the low side switch BD8LB600FS. The daisy chaining is in hardware achieved via connecting the MISO and MOSI lines of multiple instances of the IC in a row. It is implemented in the driver through a variable number of GPIOs on one instance. Therefore, one device tree instance of the IC will handle multiple daisy chained physical instances.

@benediktibk benediktibk force-pushed the add_bd8lb600fs_daisy_chaining branch 2 times, most recently from 36eab51 to 4b5e5e6 Compare November 30, 2023 14:35
@benediktibk benediktibk marked this pull request as ready for review November 30, 2023 15:34
@zephyrbot zephyrbot added area: GPIO area: Devicetree Binding PR modifies or adds a Device Tree binding labels Nov 30, 2023
@benediktibk
Copy link
Collaborator Author

@henrikbrixandersen Do you maybe have time to take a look at this one? I think Kumar and Piotr probably won't be able to do so.

drivers/gpio/gpio_bd8lb600fs.c Outdated Show resolved Hide resolved
dts/bindings/gpio/rohm,bd8lb600fs.yaml Show resolved Hide resolved
This implements the daisy chain feature of the low side switch
BD8LB600FS. The daisy chaining is in hardware achieved via
connecting the MISO and MOSI lines of multiple instances of the IC
in a row. It is implemented in the driver through a variable number
of GPIOs on one instance. Therefore, one device tree instance of the
IC will handle multiple daisy chained physical instances.

Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
Add a missing call to gpio_is_ready_dt in the driver of
the BD8LB600FS.

Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
@benediktibk
Copy link
Collaborator Author

Rebased to resolve merge conflicts.

@benediktibk benediktibk added the dev-review To be discussed in dev-review meeting label Jan 15, 2024
@benediktibk benediktibk added this to the v3.6.0 milestone Jan 24, 2024
@benediktibk benediktibk removed the dev-review To be discussed in dev-review meeting label Jan 25, 2024
@nashif nashif merged commit 5a61805 into zephyrproject-rtos:main Jan 25, 2024
18 of 19 checks passed
@benediktibk benediktibk deleted the add_bd8lb600fs_daisy_chaining branch January 29, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: GPIO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants