Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: arm: introduce support for ST Nucleo F722ZE #66050

Merged
merged 3 commits into from Dec 13, 2023

Conversation

ryukoposting
Copy link
Contributor

Nucleo F722ZE is a development board for the STM32F722ZE, one of ST's higher-end MCU offerings. Add support for the board, aligning with conventions set by similar boards already in the Zephyr distribution.

Some notes:

  • nucleo_f722ze's pinout is virtually identical to the existing nucleo_f446ze board.
  • The STM32F722XX SoC is almost identical to the existing STM32F723XX SoC. The only difference is in the USB PHY peripherals.
  • I am not affiliated with ST in any capacity.

I have tested several sample programs on my Nucleo F722ZE, including:

  • samples/hello_world
  • samples/basic/blinky
  • samples/basic/button
  • samples/drivers/watchdog
  • samples/sensor/die_temp_polling
  • samples/sensor/soc_voltage
  • samples/subsys/shell/devmem_load (with -DCONFIG_HWINFO_SHELL added)

I have also run the above samples using the USB CDC-ACM and Segger RTT as consoles.

I have also tested these samples, though they require overlay files that aren't included in this PR (I'll add those later):

  • samples/basic/fade_led
  • samples/drivers/adc
  • samples/drivers/dac

Copy link

github-actions bot commented Dec 1, 2023

Hello @ryukoposting, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@ryukoposting ryukoposting force-pushed the stm32f722ze_nucleo branch 2 times, most recently from 63a4711 to c15e3b0 Compare December 2, 2023 00:17
@zephyrbot zephyrbot added area: ADC Analog-to-Digital Converter (ADC) area: Counter area: DAC Digital-to-Analog Converter labels Dec 2, 2023
@ryukoposting
Copy link
Contributor Author

Apologies for the repeated force-pushes to get this thing going. I'm hoping this will be the last one - just a couple of tweaks to indentation in devicetree files.

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside one comment.
Also, please split the change in order to at least separate the tests changes from the board/soc additions. (Ideally also split board and soc additions but I won't block for this).

dts/arm/st/f7/stm32f722.dtsi Show resolved Hide resolved
@ryukoposting
Copy link
Contributor Author

LGTM aside one comment. Also, please split the change in order to at least separate the tests changes from the board/soc additions. (Ideally also split board and soc additions but I won't block for this).

Okay @erwango ! Just to make sure I understand properly, I should have three PRs open:

  1. The SoC definition (you're fine with me combining this with PR 2)
  2. The board definition
  3. Test overlay files for the board

Here's the thing... if I separate the test overlay files from the board definition, then tests won't pass on the second PR. Is that okay? Should I do something to force the tests to pass?

@erwango
Copy link
Member

erwango commented Dec 8, 2023

I should have three PRs open.

Sorry if I wasn't clear enough: you should split in 3 commits but keep a single PR.

The STM32F722 is similar to the STM32F723, but lacks the latter's
more advanced USB PHY. Otherwise, they are virtually identical.

Signed-off-by: Evan Perry Grove <evan@4grove.com>
Introduce support for ST Nucleo F722ZE, an evaluation board based on
the STM32F722ZET6U microcontroller.

Signed-off-by: Evan Perry Grove <evan@4grove.com>
Add overlays for the adc_api and counter_basic_api tests. Support
Nucleo F722ZE in the dac_api test.

Signed-off-by: Evan Perry Grove <evan@4grove.com>
@carlescufi carlescufi merged commit 6df4576 into zephyrproject-rtos:main Dec 13, 2023
20 checks passed
Copy link

Hi @ryukoposting!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ADC Analog-to-Digital Converter (ADC) area: Counter area: DAC Digital-to-Analog Converter platform: STM32 ST Micro STM32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants