Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tcat zephyr implementation and openthread upmerge #66160

Conversation

canisLupus1313
Copy link
Contributor

This PR introduces new version of openthread 4ed44bc.

Introduces also implementation of TCAT feature in Zephyr platform.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Dec 5, 2023

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
openthread zephyrproject-rtos/openthread@75694d2 zephyrproject-rtos/openthread@4ed44bc (main) zephyrproject-rtos/openthread@75694d28..4ed44bc7

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-openthread DNM This PR should not be merged (Do Not Merge) labels Dec 5, 2023
@canisLupus1313
Copy link
Contributor Author

@arnulfrupp @pjasinski990 FYI

Copy link
Collaborator

@edmont edmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems an initial compliance cleanup is needed.

modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
@canisLupus1313 canisLupus1313 force-pushed the tcat_zephyr_implementation branch 4 times, most recently from 186adab to 7721680 Compare December 5, 2023 15:48
@pjasinski990 pjasinski990 force-pushed the tcat_zephyr_implementation branch 2 times, most recently from 6011687 to 690b44a Compare December 6, 2023 07:58
Copy link
Collaborator

@maciejbaczmanski maciejbaczmanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to keep all logs regarding errors as LOG_WRN level

modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
@canisLupus1313 canisLupus1313 force-pushed the tcat_zephyr_implementation branch 5 times, most recently from c8e0e1e to 98de719 Compare December 7, 2023 08:23
Copy link
Collaborator

@maciejbaczmanski maciejbaczmanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed one more type cast

modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Outdated Show resolved Hide resolved
modules/openthread/platform/ble.c Show resolved Hide resolved
edmont
edmont previously approved these changes Dec 7, 2023
This commit bumps openthread commit to `4ed44bc`
and implements `CONFIG_OPENTHREAD_MULTIPAN_RCP` option.

Signed-off-by: Przemyslaw Bida <przemyslaw.bida@nordicsemi.no>
This commit adds bbtc implementation.
New file in modules/openthread/platform/ble.c
New corresponding kconfig option `OPENTHREAD_BLE_TCAT`.

Co-authored-by: Piotr Jasiński <piotr.jasinski@nordicsemi.no>

Signed-off-by: Przemyslaw Bida <przemyslaw.bida@nordicsemi.no>
Signed-off-by: Piotr Jasiński <piotr.jasinski@nordicsemi.no>
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Dec 7, 2023
@fabiobaltieri fabiobaltieri merged commit 304b983 into zephyrproject-rtos:main Dec 8, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants