Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: arm: Add RTC clock source for mikroe_mini_m4_for_stm32 #66359

Merged
merged 1 commit into from Dec 11, 2023

Conversation

ycsin
Copy link
Collaborator

@ycsin ycsin commented Dec 11, 2023

The mikroe_mini_m4_for_stm32 board doesn't have its RTC node enabled, and is failing the following test:

tests/benchmarks/footprints/benchmark.kernel.footprints.pm

This board seems to have been missed out from 44b8370, let's enable the rtc & clk_lsi here.

Fixes #66360

@ycsin ycsin marked this pull request as ready for review December 11, 2023 05:13
@ycsin ycsin added bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. backport v3.5-branch Backport to the v3.5-branch labels Dec 11, 2023
@henrikbrixandersen henrikbrixandersen requested a review from a team December 11, 2023 07:02
The `mikroe_mini_m4_for_stm32` board doesn't have its RTC node
enabled, and is failing the following test:

`tests/benchmarks/footprints/benchmark.kernel.footprints.pm`

This board seems to have been missed out from 44b8370, let's
enable the rtc & clk_lsi here.

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
@ycsin
Copy link
Collaborator Author

ycsin commented Dec 11, 2023

forced push to add:

&clk_lsi {
	status = "okay";
};

@erwango @gautierg-st I simply copied the nodes from other f4 boards since they share most of the peripherals, PTAL

@ycsin ycsin requested a review from ceolin December 11, 2023 08:57
@fabiobaltieri fabiobaltieri merged commit 54573e7 into zephyrproject-rtos:main Dec 11, 2023
13 checks passed
@ycsin ycsin deleted the pr/mikroe_stm32_rtc branch December 11, 2023 09:10
@ycsin
Copy link
Collaborator Author

ycsin commented Dec 11, 2023

96b_aerocore2 also doesn't have the necessary RTC node enabled

EDIT:
Running twister test on ST boards...

az3166_iotdevkit as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v3.5-branch Backport to the v3.5-branch bug The issue is a bug, or the PR is fixing a bug Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. platform: STM32 ST Micro STM32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Some ST boards are failing the tests/benchmarks/footprints/benchmark.kernel.footprints.pm test
4 participants