Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: esp32s2_devkitc: initial board support #66462

Merged
merged 1 commit into from Apr 8, 2024

Conversation

wmrsouza
Copy link
Contributor

Initial board files created to support the esp32s2_devkitc board.

@nordicjm
Copy link
Collaborator

Closing as duplicate of #66463

@nordicjm nordicjm closed this Dec 13, 2023
@sylvioalves sylvioalves reopened this Dec 13, 2023
@sylvioalves
Copy link
Collaborator

@nordicjm, Sorry, it is not duplicated. #66463 is esp32s3 SoC.

@nordicjm
Copy link
Collaborator

My bad, missed the 3 being different to 2 in branch name

@zephyrbot zephyrbot added area: ADC Analog-to-Digital Converter (ADC) area: DAC Digital-to-Analog Converter labels Dec 14, 2023
@wmrsouza wmrsouza force-pushed the board/esp32s2_devkitc branch 4 times, most recently from e8e49cb to 001e572 Compare December 22, 2023 13:05
Copy link

@marekmatej marekmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the openocd line, LGTM

boards/xtensa/esp32s2_devkitc/support/openocd.cfg Outdated Show resolved Hide resolved
@wmrsouza wmrsouza marked this pull request as draft January 8, 2024 13:05
@wmrsouza wmrsouza force-pushed the board/esp32s2_devkitc branch 2 times, most recently from 2e0f3ef to 4f630b8 Compare February 1, 2024 17:59
@zephyrbot
Copy link
Collaborator

zephyrbot commented Feb 1, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be migrated to hwmv2

@wmrsouza wmrsouza force-pushed the board/esp32s2_devkitc branch 3 times, most recently from e876bee to 230ba65 Compare April 2, 2024 19:32
Initial board files created to support the esp32s2_devkitc board.

Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
@wmrsouza wmrsouza marked this pull request as ready for review April 3, 2024 01:34
@wmrsouza
Copy link
Contributor Author

wmrsouza commented Apr 3, 2024

Needs to be migrated to hwmv2

It was migrated to hwmv2

Comment on lines +91 to +96
ESP-IDF bootloader
==================

The board is using the ESP-IDF bootloader as the default 2nd stage bootloader.
It is build as a subproject at each application build. No further attention
is expected from the user.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update this part to conform with the simple boot changes pending merge.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update it later.

@nashif nashif merged commit f23d06e into zephyrproject-rtos:main Apr 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ADC Analog-to-Digital Converter (ADC) area: DAC Digital-to-Analog Converter platform: ESP32 Espressif ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants