Bluetooth: Mesh: Added support for randomly delaying publications #66498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
akredalen,
alxelax,
Andrewpini,
asbjornsabo,
hermabe,
jhedberg,
LingaoM,
sjanc,
Thalley and
Vudentz
akredalen
reviewed
Dec 14, 2023
| * Between 20 to 50 milliseconds for periodically published messages | ||
|
|
||
| This feature is optional and enabled with the :kconfig:option:`CONFIG_BT_MESH_DELAYABLE_PUBLICATION` | ||
| Kconfig option. When enabled, each model can enable or the delayable publication by setting the |
There was a problem hiding this comment.
Suggested change
| Kconfig option. When enabled, each model can enable or the delayable publication by setting the | |
| Kconfig option. When enabled, each model can enable or disable the delayable publication by setting the |
subsys/bluetooth/mesh/Kconfig
Outdated
| help | ||
| When enabled, the periodic publications are randomly delayed by 20 to 50ms. Publications | ||
| triggered at the start of the stack or by the bt_mesh_model_publish() call are delayed by | ||
| 20 to 500ms. This option reduces probability of collisions when multiple nodes publish at |
There was a problem hiding this comment.
Suggested change
| 20 to 500ms. This option reduces probability of collisions when multiple nodes publish at | |
| 20 to 500ms. This option reduces the probability of collisions when multiple nodes publish at |
mia-ko
suggested changes
Dec 14, 2023
Comment on lines
261
to
262
| The delayable publication functionality implements the specification recommendations that delays | ||
| a message publication in the following cases: |
There was a problem hiding this comment.
Suggested change
| The delayable publication functionality implements the specification recommendations that delays | |
| a message publication in the following cases: | |
| The delayable publication functionality implements the specification recommendations for message | |
| publication delays in the following cases: |
alxelax
requested changes
Dec 15, 2023
subsys/bluetooth/mesh/access.c
Outdated
| return 0; | ||
| } | ||
|
|
||
| uint8_t num = 0; |
There was a problem hiding this comment.
Hm... whether uint8_t type wide is sufficient to represent random value above 256? Shouldn't it be uint16_t?
There was a problem hiding this comment.
but function still returns uint8_t value. It is still not possible to get random values in range 256 ... 500.
akredalen
previously approved these changes
Dec 15, 2023
alxelax
requested changes
Dec 15, 2023
alxelax
requested changes
Dec 15, 2023
PavelVPV
force-pushed
the
pub_rand
branch
2 times, most recently
from
6980766
to
5b0bced
Compare
The section 3.7.3.1 of the mesh specification recommends to delay a message publication in certain cases: - at power-up or upon state change for a time between 20 to 500 ms - for periodic publications for a time between 20 to 50 ms This change implements this recommendation by adding the `CONFIG_BT_MESH_DELAYABLE_PUBLICATION` Kconfig option which enables the randomization code and by adding the `bt_mesh_model_pub.delayable` bit field which allows each model decide whether the publications should be delayed for this model or not. Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
alxelax
approved these changes
Dec 15, 2023
akredalen
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The section 3.7.3.1 of the mesh specification recommends to delay a message publication in certain cases:
This change implements this recommendation by adding the
CONFIG_BT_MESH_DELAYABLE_PUBLICATIONKconfig option which enables the randomization code and by adding thebt_mesh_model_pub.delayablebit field which allows each model decide whether the publications should be delayed for this model or not.