New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: input: add an analog-axis driver #66600
Merged
carlescufi
merged 1 commit into
zephyrproject-rtos:main
from
fabiobaltieri:input-analog-axis
Jan 10, 2024
Merged
drivers: input: add an analog-axis driver #66600
carlescufi
merged 1 commit into
zephyrproject-rtos:main
from
fabiobaltieri:input-analog-axis
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobaltieri
force-pushed
the
input-analog-axis
branch
4 times, most recently
from
December 16, 2023 22:07
c3a65bb
to
867bc3c
Compare
kartben
requested changes
Dec 16, 2023
fabiobaltieri
force-pushed
the
input-analog-axis
branch
from
December 16, 2023 22:47
867bc3c
to
c36142d
Compare
fabiobaltieri
changed the title
drivers: input: add analog-axis driver
drivers: input: add an analog-axis driver
Dec 16, 2023
fabiobaltieri
force-pushed
the
input-analog-axis
branch
5 times, most recently
from
December 17, 2023 18:47
130e379
to
9bb8f38
Compare
zephyrbot
added
area: Input
Input Subsystem and Drivers
area: Devicetree Binding
PR modifies or adds a Device Tree binding
labels
Dec 17, 2023
gmarull
reviewed
Dec 18, 2023
kartben
requested changes
Dec 18, 2023
fabiobaltieri
force-pushed
the
input-analog-axis
branch
2 times, most recently
from
December 18, 2023 10:36
a3522dd
to
07b7e2a
Compare
bbilas
reviewed
Dec 19, 2023
fabiobaltieri
force-pushed
the
input-analog-axis
branch
from
December 19, 2023 19:50
07b7e2a
to
d3f4e29
Compare
|
fabiobaltieri
force-pushed
the
input-analog-axis
branch
from
December 20, 2023 00:22
d3f4e29
to
86069d6
Compare
kartben
reviewed
Dec 21, 2023
fabiobaltieri
force-pushed
the
input-analog-axis
branch
from
December 21, 2023 18:29
86069d6
to
120b5be
Compare
gmarull
reviewed
Dec 29, 2023
gmarull
reviewed
Dec 29, 2023
fabiobaltieri
force-pushed
the
input-analog-axis
branch
from
December 29, 2023 10:26
120b5be
to
4ad3cec
Compare
gmarull
previously approved these changes
Jan 2, 2024
Add an input driver to read data from an analog device, such as a thumbstick, connected to an ADC channel, and report it as an input device. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
fabiobaltieri
force-pushed
the
input-analog-axis
branch
from
January 9, 2024 11:29
4ad3cec
to
1349200
Compare
(merge conflict, rebased). |
kartben
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc looks good thanks!
kartben
reviewed
Jan 9, 2024
gmarull
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Devicetree Binding
PR modifies or adds a Device Tree binding
area: Input
Input Subsystem and Drivers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last installment (maybe) of the general purpose input drivers. This is for a generic thumbstick style device connected to an ADC to report as an absolute position input device. Been running the original version of this on one of my toy projects (predating the input subsystem), just finished making it generic, I think it'd be a great addition to the project.
The calibration factors and deadzone in the devicetree are just an initial value stored in RAM, there's an API for overwriting those as well as saving them with the settings subsystems. If saved, they are loaded at boot time automatically.
The deadzone is optional, as it's only needed for a self centering device, for a return to zero device one can just change the limits.
I'll follow up with a shell command and power management down the road, but this is big and functional enough for now.
Add an input driver to read data from an analog device, such as a thumbstick, connected to an ADC channel, and report it as an input device.