Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLE9104 output diagnostics sensor #67029

Merged

Conversation

benediktibk
Copy link
Collaborator

@benediktibk benediktibk commented Dec 27, 2023

Implement the output diagnostics of the low side switch TLE9104 as a sensor.

Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this ought to be done using an MFD. The approach taken here is the same as before we had drivers/mfd/.

@benediktibk
Copy link
Collaborator Author

I think this ought to be done using an MFD. The approach taken here is the same as before we had drivers/mfd/.

Okay, I'm gonna focus on this PR with the changes and continue working on #67030 as soon as we have settled the basics in this one.

@benediktibk benediktibk marked this pull request as draft February 14, 2024 14:47
@benediktibk benediktibk force-pushed the add_tle9104_diagnostics branch 4 times, most recently from 7ebf958 to ee49bf2 Compare February 15, 2024 11:14
@benediktibk
Copy link
Collaborator Author

Force pushed a change to set val2 as well to avoid random garbage.

@benediktibk benediktibk force-pushed the add_tle9104_diagnostics branch 2 times, most recently from 98e9bed to 6110f0c Compare March 21, 2024 12:55
@benediktibk
Copy link
Collaborator Author

Changed the order of initialization, it is necessary to configure the diagnostics before OUT_EN is set.

@benediktibk
Copy link
Collaborator Author

@MaureenHelm Could you please take a look at this PR?

@benediktibk
Copy link
Collaborator Author

Rebased onto main to resolve merge conflicts.

@benediktibk benediktibk added the dev-review To be discussed in dev-review meeting label Apr 4, 2024
MaureenHelm
MaureenHelm previously approved these changes Apr 4, 2024
@MaureenHelm MaureenHelm removed the dev-review To be discussed in dev-review meeting label Apr 4, 2024
aasinclair
aasinclair previously approved these changes Apr 4, 2024
@benediktibk
Copy link
Collaborator Author

Rebased onto main to resolve merge conflicts.

aasinclair
aasinclair previously approved these changes Apr 5, 2024
Split up the driver for the power train switch TLE9104 into a
MFD and GPIO.

Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
Implement a sensor for the output diagnostics of the power train
switch TLE9104.

Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
Add an instance of the output diagnostics sensor for the
power train switch TLE9104 to the build all tests.

Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
@benediktibk
Copy link
Collaborator Author

Rebased onto main to resolve merge conflicts.

@carlescufi carlescufi merged commit abf32ce into zephyrproject-rtos:main Apr 9, 2024
22 checks passed
@benediktibk benediktibk deleted the add_tle9104_diagnostics branch April 9, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: GPIO area: MFD area: Sensors Sensors platform: Infineon Infineon Technologies AG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants