drivers: plic: fix compilation warning when PLIC_SHELL is enabled on 64bit platform
#67193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: RISCV
ycsin
changed the title
size_t index variable
zephyrbot
requested review from
carlocaione,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
mgielda,
npitre and
tgorochowik
ycsin
force-pushed
the
pr/plic_shell_fix_format
branch
from
1cc25d1
to
79e5385
Compare
ycsin
changed the title
size_t index variable
Change the index variable type to `int` from `size_t` to compile across 32bit and 64bit platforms without generating warnings. Signed-off-by: Yong Cong Sin <ycsin@meta.com>
Store the compile-time computed length of the `irq_count` into a variable so that we have less to do in runtime. Signed-off-by: Yong Cong Sin <ycsin@meta.com>
Add a build-only test for the `PLIC_SHELL` configuration. Signed-off-by: Yong Cong Sin <ycsin@meta.com>
ycsin
force-pushed
the
pr/plic_shell_fix_format
branch
from
79e5385
to
47addd3
Compare
cfriedt
approved these changes
Jan 4, 2024
ycsin
changed the title
PLIC_SHELL is enabled on 64bit platform
carlocaione
approved these changes
Jan 8, 2024
fkokosinski
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed compilation warning on 64bit platform by changing the irq array iterator from
size_ttoint, added build-only test forPLIC_SHELLon 32bit & 64bit platforms