drivers: regulator: max20335: add support for ship mode #67222
Conversation
bbilas
force-pushed
the
drivers-max20335-add-enable-disable-functionallity
branch
10 times, most recently
from
5426b46
to
0a00b52
Compare
bbilas
force-pushed
the
drivers-max20335-add-enable-disable-functionallity
branch
from
0a00b52
to
cfd1ae2
Compare
| struct i2c_dt_spec bus; | ||
| const struct regulator_max20335_desc *desc; | ||
| uint8_t source; | ||
| const struct device *parent; |
There was a problem hiding this comment.
note: not sure you save much by doing this (I removed it from some code a while ago), as it complicates things for just an address byte, depending on alignment you may actually save nothing.
There was a problem hiding this comment.
I followed the same pattern as in pca9420. Not sure what savings you have in mind?
There was a problem hiding this comment.
Both the common and the individual regulator configs can have their own copy of struct i2c_dt_spec bus.
Then you can access ->bus directly instead of having to go via the parent.
There was a problem hiding this comment.
As you can see, struct i2c_dt_spec has been removed from the individual regulator configs. Am I still wrong, am I still blind?
There was a problem hiding this comment.
I believe Gerard is suggesting that you keep struct i2c_dt_spec bus in both the common and individual configs.
Then you don't need to get the parent config pointer, you can keep the original code.
There was a problem hiding this comment.
Thanks, I've fixed that.
Allows the user to disable PMIC. Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
bbilas
force-pushed
the
drivers-max20335-add-enable-disable-functionallity
branch
from
cfd1ae2
to
45b5199
Compare
Allows the user to disable PMIC.