drivers: sensor: add ScioSense ENS160 driver #67343
Conversation
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
avisconti,
galak,
MaureenHelm,
teburd,
tristan-google and
yperess
ggrs
force-pushed
the
ens160_driver
branch
2 times, most recently
from
96c0724
to
b70cb5c
Compare
ggrs
force-pushed
the
ens160_driver
branch
2 times, most recently
from
9e1616a
to
f63121c
Compare
|
@MaureenHelm rebase done |
ggrs
force-pushed
the
ens160_driver
branch
2 times, most recently
from
d0bcb39
to
6039cc1
Compare
drivers/sensor/ens160/ens160.c
Outdated
| return 0; | ||
| } | ||
|
|
||
| static int ens160_new_data(const struct device *dev) |
There was a problem hiding this comment.
| static int ens160_new_data(const struct device *dev) | |
| static bool ens160_new_data(const struct device *dev) |
drivers/sensor/ens160/ens160.c
Outdated
| if (FIELD_GET(ENS160_STATUS_NEWDAT, status) == 0x01) { | ||
| return 1; | ||
| } | ||
|
|
||
| return 0; |
There was a problem hiding this comment.
| if (FIELD_GET(ENS160_STATUS_NEWDAT, status) == 0x01) { | |
| return 1; | |
| } | |
| return 0; | |
| return FIELD_GET(ENS160_STATUS_NEWDAT, status) != 0; |
drivers/sensor/ens160/ens160.c
Outdated
| chan == (enum sensor_channel)SENSOR_CHAN_ENS160_AQI); | ||
|
|
||
| if (!IS_ENABLED(CONFIG_ENS160_TRIGGER)) { | ||
| WAIT_FOR((ens160_new_data(dev) == 1), ENS160_TIMEOUT_US, k_msleep(10)); |
There was a problem hiding this comment.
| WAIT_FOR((ens160_new_data(dev) == 1), ENS160_TIMEOUT_US, k_msleep(10)); | |
| WAIT_FOR(ens160_new_data(dev), ENS160_TIMEOUT_US, k_msleep(10)); |
drivers/sensor/ens160/ens160_i2c.c
Outdated
| { | ||
| const struct ens160_config *config = dev->config; | ||
|
|
||
| return i2c_burst_write_dt(&config->i2c, reg, data, len); |
There was a problem hiding this comment.
Unfortunately i2c_burst_write is problematic, so should be avoided (#20154).
You will need to create a combined write buffer here, something like:
| return i2c_burst_write_dt(&config->i2c, reg, data, len); | |
| __ASSERT(len == 2, "Only 2 byte write are supported"); | |
| uint8_t buff[] = {reg, data[0], data[1]}; | |
| return i2c_write_dt(&config->i2c, buff, sizeof(buff)); | |
| } |
Alternatively you may wish to have a write 2 registers function instead.
If it is unlikely that there will be need to writes more than 2 bytes, this is a good option.
There was a problem hiding this comment.
I was not aware of this problem. Thank you for pointing it out.
The datasheet (version 1.3) mentions in section 16.2.4 a write operation to a set of consecutive registers for configuring threshold interrupt, but some details are absent in the current revision. Therefore, this driver does not implement threshold triggers for the same reason.
However, I imagine that in a future revision the datasheet may become clearer and there will be the need for writing more than two bytes.
Because of this, I opted for your first suggestion.
Add driver for ScioSense ENS160 multi-gas sensor. The driver includes support for I2C and SPI, attributes for setting temperature and humidity compensation and data ready trigger. Also add ScioSense to the list of vendor prefixes. Signed-off-by: Gustavo Silva <gustavograzs@gmail.com>
Add driver for ScioSense ENS160 multi-gas sensor. The driver includes support for I2C and SPI, attributes for setting temperature and humidity compensation and data ready trigger. Also add ScioSense to the list of vendor prefixes.