Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: shields: Add support for X-NUCLEO-BNRG2A1 shield #67381

Merged
merged 1 commit into from Jan 15, 2024
Merged

boards: shields: Add support for X-NUCLEO-BNRG2A1 shield #67381

merged 1 commit into from Jan 15, 2024

Conversation

HoZHel
Copy link
Contributor

@HoZHel HoZHel commented Jan 9, 2024

Add support for X-NUCLEO-BNRG2A1 which is a BLE expansion board based on the BLUENRG-M2SP.

@HoZHel HoZHel marked this pull request as ready for review January 10, 2024 14:39
@zephyrbot zephyrbot added the area: Shields Shields (add-on boards) label Jan 10, 2024
kartben
kartben requested changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc looks good, thanks! Would be nice to have a WEBP image please (I need to update doc guidelines at some point...), as the proposed JPEG image has poor quality relative to its file size. Thanks!

boards/shields/x_nucleo_bnrg2a1/doc/img/x-nucleo-bnrg2a1.jpg Outdated Show resolved Hide resolved
avisconti
avisconti previously approved these changes Jan 12, 2024
View reviewed changes
@HoZHel HoZHel dismissed stale reviews from avisconti and erwango via 14d4e0e January 12, 2024 15:16
@HoZHel
boards: shields: Add support for X-NUCLEO-BNRG2A1 shield
5ece815 
Add support for X-NUCLEO-BNRG2A1 which is a BLE expansion board based on
the BLUENRG-M2SP.

Signed-off-by: Ali Hozhabri <ali.hozhabri@st.com>
@carlescufi carlescufi merged commit 85995e5 into zephyrproject-rtos:main Jan 15, 2024
18 checks passed
@HoZHel HoZHel deleted the x_nucleo_bnrg2a1 branch January 15, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avisconti avisconti avisconti approved these changes

@kartben kartben kartben approved these changes

@erwango erwango erwango approved these changes

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@fabiobaltieri fabiobaltieri Awaiting requested review from fabiobaltieri

Assignees

@erwango erwango

Labels
area: Shields Shields (add-on boards)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@HoZHel @avisconti @kartben @erwango @carlescufi @zephyrbot