Some Xtensa cores do not support NMI #67853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: "Backport Issue Check / Backport Issue Check" failed because I didn't add |
dcpleung
reviewed
Jan 19, 2024
dcpleung
reviewed
Jan 19, 2024
andyross
approved these changes
Jan 19, 2024
|
Fixed suggestions made by @dcpleung |
dcpleung
approved these changes
Jan 19, 2024
dcpleung
requested changes
Jan 19, 2024
…MILEVEL won't be defined at all causing `arch/xtensa/include/xtensa-asm2-s.h` to throw compilation error. Review fixes
rysiof
force-pushed
the
fix_xtensa_no_nmi
branch
from
d2ce7c8
to
d76aadd
Compare
dcpleung
approved these changes
Jan 19, 2024
NOTE: This is for v2.7 branch. |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
not needed in 2.7 anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Xtensa cores do not support NMI, so XCHAL_HAVE_NMI=0 and XCHAL_NMILEVEL won't be defined at all causing
arch/xtensa/include/xtensa-asm2-s.hto throw compilation error.Fixes: #67855