Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: power-domain: Add option for initialization priority #67939

Merged
merged 3 commits into from Jan 24, 2024
Merged

drivers: power-domain: Add option for initialization priority #67939

merged 3 commits into from Jan 24, 2024

Conversation

ceolin
Copy link
Member

@ceolin ceolin commented Jan 22, 2024

Add a build option to change specific power domains initialization priority.

@ceolin
drivers: power_domain/gpio_monitor: Init priority option
477c5df 
Add a Kconfig option to customize initialization priority of
gpio monitor power domain.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
@ceolin
drivers: power_domain/gpio: Init priority option
51412f2 
Add a Kconfig option to customize initialization priority of
gpio power domain.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
@ceolin
drivers: power_domain/intel_adsp: Init priority option
bd89953 
Add a Kconfig option to customize initialization priority of
Intel ADSP power domain.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
@ceolin ceolin linked an issue Jan 22, 2024 that may be closed by this pull request
power-domain-gpio **must** have configurable init priority #67467
Closed
henrikbrixandersen
henrikbrixandersen approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general you should use depends on for single Kconfig options depending on something else, and only use if ... endif when multiple options share the same dependency.

@ceolin
Copy link
Member Author

ceolin commented Jan 24, 2024

In general you should use depends on for single Kconfig options depending on something else, and only use if ... endif when multiple options share the same dependency.

cool, thanks for the tip. Btw, is it documented anywhere ?

@henrikbrixandersen
Copy link
Member

cool, thanks for the tip. Btw, is it documented anywhere ?

Not to that detail, I think. There's a hint here, but for the inverse case: https://docs.zephyrproject.org/latest/build/kconfig/tips.html#factoring-out-common-dependencies

@nashif nashif merged commit 4e39f79 into zephyrproject-rtos:main Jan 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@JordanYates JordanYates JordanYates approved these changes

@tmleman tmleman tmleman approved these changes

@nashif nashif Awaiting requested review from nashif

@teburd teburd Awaiting requested review from teburd

Assignees

@ceolin ceolin

Labels
area: Power Management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

power-domain-gpio **must** have configurable init priority
6 participants
@ceolin @henrikbrixandersen @JordanYates @tmleman @nashif @zephyrbot