Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: watchdog: support for Nuvoton numaker WWDT #68044

Merged
merged 2 commits into from Mar 3, 2024
Merged

drivers: watchdog: support for Nuvoton numaker WWDT #68044

merged 2 commits into from Mar 3, 2024

Conversation

cyliangtw
Copy link
Contributor

This PR is to add Nuvoton numaker window watchdog.
It's verified on board: NuMaker-PFM-M467.

@zephyrbot zephyrbot added area: Watchdog Watchdog area: Devicetree Binding PR modifies or adds a Device Tree binding platform: Nuvoton NPCX Nuvoton NPCX platform: Nuvoton Numicro Numaker Nuvoton Technology Corporation, Numicro Numaker labels Jan 24, 2024
fabiobaltieri
fabiobaltieri reviewed Jan 24, 2024
View reviewed changes
drivers/watchdog/wdt_wwdt_numaker.c Outdated Show resolved Hide resolved
drivers/watchdog/wdt_wwdt_numaker.c Outdated Show resolved Hide resolved
drivers/watchdog/wdt_wwdt_numaker.c Outdated Show resolved Hide resolved
drivers/watchdog/wdt_wwdt_numaker.c Outdated Show resolved Hide resolved
drivers/watchdog/wdt_wwdt_numaker.c Outdated Show resolved Hide resolved
drivers/watchdog/wdt_wwdt_numaker.c Outdated Show resolved Hide resolved
drivers/watchdog/wdt_wwdt_numaker.c Outdated Show resolved Hide resolved
fabiobaltieri
fabiobaltieri previously approved these changes Jan 25, 2024
View reviewed changes
@cyliangtw
Copy link
Contributor Author

Hi @ssekar15,
If you are available, please look into this PR.

@cyliangtw cyliangtw requested review from martinjaeger and dcpleung and removed request for martinjaeger January 30, 2024 08:40
@ssekar15
Copy link
Collaborator

Hi @ssekar15, If you are available, please look into this PR.

bit hooked up, will have look shortly. Thanks

@cyliangtw
drivers: watchdog: support Nuvoton numaker WWDT
5e92c8a 
Add Nuvoton numaker series window watchdog feature.

Signed-off-by: cyliang tw <cyliang@nuvoton.com>
@cyliangtw
tests: drivers: watchdog: wdt_basic_api: support numaker_pfm_m467
0fdbd9b 
Add support for Nuvoton numaker board numaker_pfm_m467.

Signed-off-by: cyliang tw <cyliang@nuvoton.com>
@cyliangtw
Copy link
Contributor Author

Rebased on main to fix the conflicting file dts/arm/nuvoton/m46x.dtsi .

ssekar15
ssekar15 approved these changes Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@ssekar15 ssekar15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@fabiobaltieri fabiobaltieri assigned cyliangtw and unassigned MulinChao Feb 5, 2024
@cyliangtw
Copy link
Contributor Author

Hi @fabiobaltieri,
After assigned me cyliangtw, what should I do except waiting to merge ?

@fabiobaltieri
Copy link
Member

@cyliangtw sorry unfortunately we missed the cut for RC1 so we have to wait until the 3.6 release, that's schedule for Feb 23.

@fabiobaltieri fabiobaltieri added this to the v3.7.0 milestone Feb 6, 2024
@cyliangtw
Copy link
Contributor Author

@cyliangtw sorry unfortunately we missed the cut for RC1 so we have to wait until the 3.6 release, that's schedule for Feb 23.

@fabiobaltieri ,
never mind, end of Feb. is fine.

@aescolar aescolar added the hwmv2-likely-conflict DNM until collab-hwmv2 has been merged label Feb 26, 2024
@cyliangtw
Copy link
Contributor Author

Hi @aescolar,
This PR is not to change any file in \zephyr\boards\arm\numaker_pfm_m467, or any file in \zephyr\soc.
It seems not hwmv2-likely-conflict.

@aescolar
Copy link
Member

@cyliangtw This label is only meant as an aid for the release engineering team, and only implies the PR will need to wait, hopefully, less than 1 week until it is merged.
Due to the work in the hwmv2 branch, and its imminent merge in the main branch, we are being overly cautious with merging PRs that change something which may conflict, specially samples/tests which change overlays or test definitions to avoid merge conflicts with that branch.

@cyliangtw
Copy link
Contributor Author

@aescolar ,
Thanks, I see.

@carlescufi carlescufi merged commit c4b5b28 into zephyrproject-rtos:main Mar 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@martinjaeger martinjaeger martinjaeger approved these changes

@ssekar15 ssekar15 ssekar15 approved these changes

@MulinChao MulinChao Awaiting requested review from MulinChao MulinChao is a code owner

@ChiHuaL ChiHuaL Awaiting requested review from ChiHuaL ChiHuaL is a code owner

@galak galak Awaiting requested review from galak

@jackrosenthal jackrosenthal Awaiting requested review from jackrosenthal

@katsuster katsuster Awaiting requested review from katsuster

@keith-zephyr keith-zephyr Awaiting requested review from keith-zephyr

@sjg20 sjg20 Awaiting requested review from sjg20

@dcpleung dcpleung Awaiting requested review from dcpleung

Assignees

@cyliangtw cyliangtw

Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Watchdog Watchdog hwmv2-likely-conflict DNM until collab-hwmv2 has been merged platform: Nuvoton NPCX Nuvoton NPCX platform: Nuvoton Numicro Numaker Nuvoton Technology Corporation, Numicro Numaker
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cyliangtw @ssekar15 @fabiobaltieri @aescolar @martinjaeger @carlescufi @zephyrbot @MulinChao