Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: adc: add ADC_DT_SPEC_*_BY_NAME() macros #68247

Merged

Conversation

msalau
Copy link
Contributor

@msalau msalau commented Jan 29, 2024

The commit adds macros to get ADC io-channel information from devicetree by name.

@zephyrbot zephyrbot added the area: ADC Analog-to-Digital Converter (ADC) label Jan 29, 2024
@zephyrbot zephyrbot requested a review from anangl January 29, 2024 18:50
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test coverage for these new macros.

The commit adds macros to get ADC io-channel information
from devicetree by name.

Signed-off-by: Maksim Salau <maksim.salau@gmail.com>
@msalau
Copy link
Contributor Author

msalau commented Jan 30, 2024

Hello @henrikbrixandersen
I've added a test but I'm not sure that it ended up in the right place.
The test suite is the only one that has io-channel-names property defined.

@decsny decsny assigned decsny and unassigned anangl Mar 11, 2024
@henrikbrixandersen henrikbrixandersen merged commit a9c2d81 into zephyrproject-rtos:main Mar 11, 2024
19 checks passed
@msalau msalau deleted the add-adc-dt-spec-by-name branch March 13, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ADC Analog-to-Digital Converter (ADC) area: Devicetree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants