Bluetooth: CAP: Shell: Add proper broadcast commands #68550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
hermabe,
jhedberg,
kruithofa,
larsgk,
MariuszSkamra,
pin-zephyr,
sjanc and
Vudentz
larsgk
reviewed
Feb 6, 2024
| @@ -48,7 +48,8 @@ Using the CAP Initiator | |||
| ======================= | |||
|
|
|||
| When the Bluetooth stack has been initialized (:code:`bt init`), the Initiator can discover CAS and | |||
| the optionally included CSIS instance by calling (:code:`cap_initiator discover`). | |||
| the optionally included CSIS instance by calling (:code:`cap_initiator discover`). The CAP initiator | |||
| also does broadcast audio. | |||
There was a problem hiding this comment.
" ..source"? (might be implicit, but better to be specific to avoid confusion)
Thalley
force-pushed
the
cap_shell_broadcast
branch
from
ccc1aa9
to
dba9547
Compare
fredrikdanebjer
requested changes
Feb 7, 2024
| data_array[ad_len].type = BT_DATA_SVC_DATA16; | ||
| data_array[ad_len].data_len = base_buf.len; | ||
| data_array[ad_len].data = base_buf.data; | ||
| ad_len++; |
There was a problem hiding this comment.
Suggest that you change this so that it does not use an incremented variable in this way. This would make it a bit clearer I believe.
Adds additional broadcast commands and modifies the existing ones to use the CAP API. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
cap_shell_broadcast
branch
from
dba9547
to
84ddfec
Compare
kruithofa
approved these changes
Feb 13, 2024
jhedberg
approved these changes
Feb 13, 2024
fredrikdanebjer
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional broadcast commands and modifies the existing ones to use the CAP API.
fixes #55511