sensors: Add Angst+Pfister FXC-MDLx5-series driver #68689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
avisconti,
galak,
MaureenHelm,
teburd,
tristan-google and
yperess
jeppenodgaard
force-pushed
the
jepod/fcx-mldxx-diff
branch
2 times, most recently
from
0df4b9a
to
0e112e0
Compare
MaureenHelm
reviewed
Feb 7, 2024
drivers/sensor/fcx_mldx5/fcx_mldx5.c
Outdated
| command_received); | ||
| return -EIO; | ||
| } else if (data->frame[FCX_MLDX5_ETX_INDEX(data->frame_len)] != FCX_MLDX5_ETX) { | ||
| LOG_WRN("No ETX"); |
There was a problem hiding this comment.
Is there a reason not to use LOG_ERR for all of these error cases?
There was a problem hiding this comment.
Is there a reason not to use
LOG_ERRfor all of these error cases?
Fixed. Also pipeline passes now.
jeppenodgaard
force-pushed
the
jepod/fcx-mldxx-diff
branch
from
dca9646
to
3a14f4f
Compare
added 6 commits
February 15, 2024 10:26
Add vendor prefix for Angst+Pfister. Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
Add bindings for the FCX-MLDx5 O2 sensor. Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
Add an enum value to support O2 sensors. Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
Add driver for Angst+Pfister O2 sensors FCX-MLD25 & FCX-MLD95 and maybe more. Tested with FCX-MLD25. Supports get O2 value, get status, and power management. Note that in suspended power mode heating output is at 20 %, thus probably not suited for a battery powered device. Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
Add FCX_MLDx5 uart node in the build_all tests. Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
Fix compile warnings cause by removing drv_data in some functions. Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
jeppenodgaard
force-pushed
the
jepod/fcx-mldxx-diff
branch
from
3a14f4f
to
36a7d8a
Compare
MaureenHelm
approved these changes
Mar 21, 2024
nashif
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add driver for Angst+Pfister O2 sensors FCX-MLD25 & FCX-MLD95 and maybe
more. Tested with FCX-MLD25.
Supports get O2 value, get status, and power management.
Note that in suspended power mode heating output is at 20 %, thus
probably not suited for a battery powered device.