drivers: mbox: add initial drivers for nRF VEVIF & BELLBOARD #69303

gmarull · 2024-02-21T17:08:29Z

Tested with:

west build -b nrf54h20pdk/nrf54h20/cpuapp samples/drivers/mbox -T sample.drivers.mbox.nrf54h20_vevif -p
west build -b nrf54h20pdk/nrf54h20/cpuapp samples/drivers/mbox -T sample.drivers.mbox.nrf54h20_bellboard -p

Pending:

DTize mbox API, so that things are more ergonomic (dt_spec from #mbox-cells) see drivers: mbox: cleanups and API improvements #69390
Refactor sample to use dt-spec stuff (depends on drivers: mbox: cleanups and API improvements #69390)
Test VEVIF+BELLBOARD together (ie bidirectional) (depends on drivers: mbox: cleanups and API improvements #69390, as current sample doesn't deal with 2 different mboxes now)

drivers/mbox/mbox_nrf_bellboard_local.c

57300

LGTM, just minor comments below.

samples/drivers/mbox/boards/nrf54h20pdk_nrf54h20_cpuapp_bellboard.overlay

samples/drivers/mbox/sample.yaml

drivers/mbox/mbox_nrf_bellboard_local.c

Set driver to initialize at early POST_KERNEL, so that we make sure other future dependencies priorities (eg VEVIF) do not conflict. Upstream PR: zephyrproject-rtos/zephyr#69303 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com> (cherry picked from commit 3e8ea343878acabdf163d1a084cef61f8e077ed5) (cherry picked from commit 851de7e) (cherry picked from commit 1bcad2f) Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>

By adding Kconfig options for both samples. Upstream PR: zephyrproject-rtos/zephyr#69303 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com> (cherry picked from commit 253593c966f339e7aebbdbbbb8126963f3529ebe) (cherry picked from commit a170171) (cherry picked from commit 5529abc) Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>

This can be useful to provide multiple setups, eg unidirectional ping-pong. Upstream PR: zephyrproject-rtos/zephyr#69303 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com> (cherry picked from commit 5cb43795d8082be70e4a18f90e66c50122f3c293) (cherry picked from commit 20f4571) (cherry picked from commit e4189b3) Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>

- Include cleanup - s/NET/REMOTE (remote core may have nothing to do with NET) - Improved error reporting Upstream PR: zephyrproject-rtos/zephyr#69303 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com> (cherry picked from commit cf67d54ed49d896112a285044a12a28b7dfacff0) (cherry picked from commit 56cc531) (cherry picked from commit fdd4cbe) Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>

Add nodes for APP/RAD BELLBOARD peripherals. Upstream PR: zephyrproject-rtos/zephyr#69303 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com> (cherry picked from commit 19dca26c3c2801123b6c4e7e9d7915dba4f4ccce) (cherry picked from commit 831c6b0) (cherry picked from commit eadc28b) Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>

Add a new nodes for PPR's VEVIF. In app cores, VEVIF registers are part of the VPR peripheral, so it is exposed as a child node (since it requires its own properties, eg #mbox-cells). In VPR, it's a CPU child since it's not a memory-mapped peripheral, but used with CSRs. Upstream PR: zephyrproject-rtos/zephyr#69303 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com> (cherry picked from commit 901708525cd5fdeabdea78d3272c2639d796c0d0) (cherry picked from commit 743cc86) (cherry picked from commit eb64ac1) Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>

Add IPC shared memory regions in the global RAM, as well as an enlarged SRAM region for Application core. Upstream PR: zephyrproject-rtos/zephyr#69303 Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no> (cherry picked from commit 7a5f20bc041a73d89484607bdf0fb8001bf146f3) (cherry picked from commit 458185d) (cherry picked from commit ccbbadf) Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>

Add `zephyr,ipc-icmsg*` nodes, with mboxes specified in a common file. Upstream PR: zephyrproject-rtos/zephyr#69303 Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no> Signed-off-by: Gerard Marull-Partetas <gerard@teslabs.com> (cherry picked from commit 035adef5768e79f4466e1f74dcd501efc39e2dc2) (cherry picked from commit 6319eaa) (cherry picked from commit f256013) Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>

Add support for nRF VEVIF. Upstream PR: zephyrproject-rtos/zephyr#69303 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com> (cherry picked from commit d40fd1f886666d0d61a7a555439857c5654bec55) (cherry picked from commit 599986a) (cherry picked from commit a66f3be) Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>

Add support for testing BELLBOARD between cpuapp (local) and cpuppr (remote). Upstream PR: zephyrproject-rtos/zephyr#69303 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com> (cherry picked from commit 54d64e39a00b6ef9383ea46eb79a409e11ccc189) (cherry picked from commit bd0efe3) (cherry picked from commit 34e58ef) Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>