New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: dhcpv4: set syslog server for log_backend_net via dhcpv4 option #69328
Merged
fabiobaltieri
merged 4 commits into
zephyrproject-rtos:main
from
VOGL-electronic:syslog_dhcpv4_option
Mar 8, 2024
Merged
net: dhcpv4: set syslog server for log_backend_net via dhcpv4 option #69328
fabiobaltieri
merged 4 commits into
zephyrproject-rtos:main
from
VOGL-electronic:syslog_dhcpv4_option
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
dcpleung,
jukkar,
nordic-krch,
rlubos,
ssharks and
tbursztyka
February 22, 2024 10:12
rlubos
reviewed
Feb 22, 2024
jukkar
reviewed
Feb 22, 2024
maass-hamburg
force-pushed
the
syslog_dhcpv4_option
branch
2 times, most recently
from
February 22, 2024 12:28
b4d90b2
to
b28cf73
Compare
maass-hamburg
force-pushed
the
syslog_dhcpv4_option
branch
2 times, most recently
from
February 22, 2024 12:37
7b561b4
to
14e4e83
Compare
rlubos
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final request, otherwise looks ok.
maass-hamburg
force-pushed
the
syslog_dhcpv4_option
branch
from
February 22, 2024 13:22
14e4e83
to
030dfba
Compare
maass-hamburg
force-pushed
the
syslog_dhcpv4_option
branch
from
February 22, 2024 13:29
030dfba
to
509e74f
Compare
rlubos
previously approved these changes
Feb 22, 2024
jukkar
requested changes
Feb 22, 2024
maass-hamburg
force-pushed
the
syslog_dhcpv4_option
branch
from
February 22, 2024 16:58
509e74f
to
7674adb
Compare
rlubos
previously approved these changes
Feb 23, 2024
maass-hamburg
force-pushed
the
syslog_dhcpv4_option
branch
from
February 26, 2024 14:59
7674adb
to
f4d9f3e
Compare
rebased, so that #69090 is included and option 7 (Log Server) will be requested from the dhcpv4 server |
rlubos
previously approved these changes
Feb 27, 2024
jukkar
previously approved these changes
Feb 27, 2024
maass-hamburg
force-pushed
the
syslog_dhcpv4_option
branch
from
February 29, 2024 07:00
f4d9f3e
to
0a907ec
Compare
rebase to resolve merge conflicts |
Adds a function to set the syslog server ip with a struct sockaddr, so that it can be set without a string. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
This moves the declaration of log_backend_net_get() to zephyr/logging/log_backend_net.h Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
Adds a function to start log_backend_net Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
Adds the option to set the log_backend_net ip via dhcpv4 option 7. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
maass-hamburg
force-pushed
the
syslog_dhcpv4_option
branch
from
February 29, 2024 07:50
0a907ec
to
695634b
Compare
rlubos
approved these changes
Feb 29, 2024
jukkar
approved these changes
Mar 1, 2024
ping @nordic-krch |
nordic-krch
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to use dhcpv4 option 7 (Log Server) to set the ip address of log_backend_net.