Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: dhcpv4: set syslog server for log_backend_net via dhcpv4 option #69328

Merged

Conversation

maass-hamburg
Copy link
Collaborator

This adds the option to use dhcpv4 option 7 (Log Server) to set the ip address of log_backend_net.

include/zephyr/logging/log_backend_net.h Outdated Show resolved Hide resolved
include/zephyr/logging/log_backend_net.h Outdated Show resolved Hide resolved
subsys/logging/backends/Kconfig.net Outdated Show resolved Hide resolved
subsys/logging/backends/log_backend_net.c Show resolved Hide resolved
subsys/logging/backends/log_backend_net.c Outdated Show resolved Hide resolved
subsys/net/lib/dhcpv4/dhcpv4.c Outdated Show resolved Hide resolved
subsys/net/lib/dhcpv4/dhcpv4.c Outdated Show resolved Hide resolved
subsys/net/lib/dhcpv4/dhcpv4.c Outdated Show resolved Hide resolved
subsys/net/lib/dhcpv4/dhcpv4.c Show resolved Hide resolved
@maass-hamburg maass-hamburg force-pushed the syslog_dhcpv4_option branch 2 times, most recently from b4d90b2 to b28cf73 Compare February 22, 2024 12:28
@maass-hamburg maass-hamburg force-pushed the syslog_dhcpv4_option branch 2 times, most recently from 7b561b4 to 14e4e83 Compare February 22, 2024 12:37
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final request, otherwise looks ok.

subsys/net/lib/dhcpv4/dhcpv4.c Outdated Show resolved Hide resolved
rlubos
rlubos previously approved these changes Feb 22, 2024
subsys/net/lib/dhcpv4/dhcpv4.c Outdated Show resolved Hide resolved
rlubos
rlubos previously approved these changes Feb 23, 2024
@maass-hamburg
Copy link
Collaborator Author

rebased, so that #69090 is included and option 7 (Log Server) will be requested from the dhcpv4 server

rlubos
rlubos previously approved these changes Feb 27, 2024
jukkar
jukkar previously approved these changes Feb 27, 2024
@maass-hamburg
Copy link
Collaborator Author

rebase to resolve merge conflicts

Adds a function to set the syslog server ip with a struct sockaddr,
so that it can be set without a string.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
This moves the declaration of log_backend_net_get() to
zephyr/logging/log_backend_net.h

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
Adds a function to start log_backend_net

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
Adds the option to set the log_backend_net ip via dhcpv4
option 7.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
@maass-hamburg
Copy link
Collaborator Author

ping @nordic-krch

@fabiobaltieri fabiobaltieri merged commit 0d776d3 into zephyrproject-rtos:main Mar 8, 2024
23 checks passed
@maass-hamburg maass-hamburg deleted the syslog_dhcpv4_option branch March 15, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants