Bluetooth: Check buffer length in GATT rsp functions #69396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
hermabe,
jhedberg,
jori-nordic,
sjanc,
Thalley and
theob-pro
jori-nordic
previously approved these changes
Feb 23, 2024
theob-pro
previously approved these changes
Feb 23, 2024
Thalley
requested changes
Feb 23, 2024
alwa-nordic
dismissed stale reviews from theob-pro and jori-nordic
via
0a8f3f6
alwa-nordic
force-pushed
the
gatt-cb-len-check
branch
from
52d1d73
to
0a8f3f6
Compare
Thalley
previously approved these changes
Feb 23, 2024
ceolin
previously approved these changes
Feb 23, 2024
theob-pro
previously approved these changes
Feb 26, 2024
Add length checks local to the parsing function. This removes the need for a separate data validation step. Signed-off-by: Aleksander Wasaznik <aleksander.wasaznik@nordicsemi.no>
alwa-nordic
dismissed stale reviews from theob-pro, ceolin, and Thalley
via
c8e4cf3
alwa-nordic
force-pushed
the
gatt-cb-len-check
branch
from
0a8f3f6
to
c8e4cf3
Compare
Thalley
approved these changes
Feb 26, 2024
jori-nordic
approved these changes
Feb 26, 2024
jhedberg
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add length checks local to the parsing function. This removes the need for a separate data validation step.