drivers: bluetooth: hci: Support raw mode in ST HCI SPI BT driver #69623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
reviewed
Feb 29, 2024
HoZHel
requested review from
alwa-nordic,
jhedberg,
Vudentz and
avisconti
as code owners
zephyrbot
added
area: Shields
zephyrbot
requested review from
ABOSTM,
Desvauxm-st,
FRASTM,
gautierg-st,
GeorgeCGV,
hermabe,
jfischer-no,
jori-nordic and
kartben
erwango
reviewed
Mar 1, 2024
| return 0; | ||
| } | ||
|
|
||
| static const struct bt_hci_driver drv = { | ||
| .name = DEVICE_DT_NAME(DT_DRV_INST(0)), | ||
| .bus = BT_HCI_DRIVER_BUS_SPI, | ||
| #if defined(CONFIG_BT_BLUENRG_ACI) | ||
| .quirks = BT_QUIRK_NO_RESET, |
There was a problem hiding this comment.
So BT_QUIRK_NO_RESET is now applied for !CONFIG_BT_BLUENRG_ACI configs.
Does it relate to current change done in this commit ? If yes, can you elaborate in commit message ?
There was a problem hiding this comment.
Since this driver is only for ST HCI SPI protocol, BT_QUIRK_NO_RESET always applies. In other words, as it was inherited from spi.c, it should have not been there since the beginning. I will add the note to the commit message.
jhedberg
previously approved these changes
Mar 1, 2024
Move bt_spi_send_aci_config to setup function. Signed-off-by: Ali Hozhabri <ali.hozhabri@st.com>
Add raw mode in ST HCI SPI BT driver to support host-less configuration. Remove compilation dependency for BT_QUIRK_NO_RESET as it applies to all configurations. Signed-off-by: Ali Hozhabri <ali.hozhabri@st.com>
…I v1 Exclude devices based on ST SPI protocol v2 from special handling of hci_reset opcode as it is redundant. Signed-off-by: Ali Hozhabri <ali.hozhabri@st.com>
Provide support for BlueNRG-based boards to run samples required raw mode. Signed-off-by: Ali Hozhabri <ali.hozhabri@st.com>
jhedberg
approved these changes
Mar 4, 2024
erwango
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide raw mode in ST HCI SPI Bluetooth driver to support host-less configuration.