drivers: flash: Add flash driver for MRAM #69800
Conversation
Upstream PR: zephyrproject-rtos/zephyr#69800 Basic driver utilizing the flash API for NVM operations on the nRF54H20. Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no> (cherry picked from commit 0797e3c)
There was a problem hiding this comment.
Looks OK, although I think that we are missing "erase-block-size" optional binding in DTS for the MRAM, and write-block-size being read from the DTS.
The second issue seems to be also on soc-nrf-flash driver, so will not insist on implementing.
The first one seems controversial, but if author will not pursue we can just do another PR with the change to binding and driver.
Upstream PR: zephyrproject-rtos/zephyr#69800 Basic driver utilizing the flash API for NVM operations on the nRF54H20. Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no> (cherry picked from commit d3b56679837ce4045d9e2618a25d7e85168eeeb9)
drivers/flash/Kconfig.nrf_mram
Outdated
| This is supported in hardware, but it requires slightly more code to | ||
| perform the operations safely. | ||
|
|
||
| config SOC_FLASH_NRF_MRAM_LAYOUT_PAGE_SIZE |
There was a problem hiding this comment.
LGTM, but
This should be moved to the dts or fixed in the driver. This will avoid any confusion:
- there are drivers where this isn't specified in the dts (because the blocks vary in size) in that case it is fixed by the driver.
- there are drivers where this is specified and then it is used for the page layout.
Adding it as a kconfig might result in applications on the same device that get stuck because they where compiled with different kconfig options.
In case where ONE_BYTE_WRITE_ACCESS is not selected it should also be a multiple of the write-block-size.
There was a problem hiding this comment.
To be fair, also the ONE_BYTE_WRITE_ACCESS should also come from the dts (by setting write-block-size equal to 1). But I didn't check how this is done on other drivers.
There was a problem hiding this comment.
Alright, I'll move both Kconfigs to DT. I realize now that both write-block-size and erase-block-size seem to be treated as configurable anyway, which is strange, but I can play along. I'd like to come back to this at a future date.
Basic driver utilizing the flash API for NVM operations on the nRF54H20. Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
The MRAM has no concept of erase blocks or pages, so this is treated as driver configuration. Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no>
Upstream PR: zephyrproject-rtos/zephyr#69800 Basic driver utilizing the flash API for NVM operations on the nRF54H20. Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no> (cherry picked from commit 25b932167764cbec99f1e932703eb7da67a434eb)
…am1x Upstream PR: zephyrproject-rtos/zephyr#69800 The MRAM has no concept of erase blocks or pages, so this is treated as driver configuration. Signed-off-by: Grzegorz Swiderski <grzegorz.swiderski@nordicsemi.no> (cherry picked from commit 8f8a078ffee5fbc066666f6ae8c0c295ab6bdb36)
Basic driver utilizing the flash API for NVM operations on the nRF54H20.