New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwmv2: Added Board Support for Starfive VisionFive2 RISC-V Single Board Computer #69814
hwmv2: Added Board Support for Starfive VisionFive2 RISC-V Single Board Computer #69814
Conversation
boards/starfive/visionfive2_jh7110/visionfive2_jh7110_defconfig
Outdated
Show resolved
Hide resolved
f85d066
to
2189130
Compare
2849c7e
to
9efaae8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit 3:
- title and body should just mention the introduction of a new board
- CODEOWNERS and MAINTAINERS.yml changes should be in another commit (probably the last commit)
commit 4:
- should be squashed with the commit that introduced the 7110 soc
commit 5:
- should be squashed with the commit that introduced that yaml file
We generally dont make another commit to just "address maintainers' comments". Rather these requested changes should be made and squashed with the commit that introduced the changes initially where it makes sense.
9efaae8
to
dfda351
Compare
@ycsin I have updated the commits according to your suggested changes. |
dfda351
to
12b12c2
Compare
12b12c2
to
dbadbab
Compare
MAINTAINERS.yml
Outdated
- pfarwsi | ||
- kanakshilledar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to agree with @kartben on this one. I've noticed that the usual path people take to be responsible for an area of Zephyr is as follows:
- contribute & in general - interact with the community (you're here)
- start reviewing other people's code
- become a collaborator
- become a maintainer
We're of course more than happy to have you and your contributions here. That being said, being responsible for the RISC-V architecture as a whole means you need to have the broader picture, be aware of all the different conventions the project conforms to and so on. And I'm just not sure if that's true for you, having only one PR under your belt.
IMO a smaller area would be better for a new member of the community, i.e. a StarFive-specific one (e.g. see the ITE platforms area) which @ycsin proposed here: https://github.com/zephyrproject-rtos/zephyr/pull/69814/files#r1514001131.
I'm unresolving this thread for now, as this IMO needs more discussion.
dad9d71
to
3ba0ae5
Compare
These list of files add basic support for StarFive JH7110 SOC Device Tree includes for VisionFive2 board. Signed-off-by: Pratik Farkase <pratik.farkase@wsisweden.com>
These list of files add Kconfig support for Starfive JH7110 SOC support. Signed-off-by: Pratik Farkase <pratik.farkase@wsisweden.com>
these list of patches add support the Starfive Visionfive2 SBC based on the JH7110 SoC. Board identifier is `visionfive2`. Signed-off-by: Kanak Shilledar <kanakshilledar111@protonmail.com> Signed-off-by: Pratik Farkase <pratik.farkase@wsisweden.com>
6cbbbcf
to
6c19987
Compare
6c19987
to
87365cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last commit title and body should be updated
87365cd
to
59bb9e9
Compare
@ycsin I have incorporated the suggested changes in the last commit message title and body |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nit, LGTM otherwise.
added files for VisionFive 2 board and JH7110 SoC under the RISCV Arch area. Signed-off-by: Kanak Shilledar <kanakshilledar111@protonmail.com>
59bb9e9
to
7cd7fc9
Compare
These list of patches contain Board support files for running Zephyr on the Starfive VisionFive2 RISC-V Single Board Computer based on JH7110 SOC. It's a basic support, no drivers other than UART have been tested.
@ycsin @aescolar