Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwmv2: Added Board Support for Starfive VisionFive2 RISC-V Single Board Computer #69814

Merged
merged 4 commits into from Mar 13, 2024

Conversation

pfarwsi
Copy link
Contributor

@pfarwsi pfarwsi commented Mar 5, 2024

These list of patches contain Board support files for running Zephyr on the Starfive VisionFive2 RISC-V Single Board Computer based on JH7110 SOC. It's a basic support, no drivers other than UART have been tested.

@ycsin @aescolar

boards/starfive/visionfive2_jh7110/doc/img/Visionfive2.jpg Outdated Show resolved Hide resolved
boards/starfive/visionfive2_jh7110/doc/index.rst Outdated Show resolved Hide resolved
boards/starfive/visionfive2_jh7110/visionfive2_jh7110.yaml Outdated Show resolved Hide resolved
soc/starfive/jh71xx/Kconfig.soc Outdated Show resolved Hide resolved
@pfarwsi pfarwsi requested a review from nordicjm March 5, 2024 16:28
@pfarwsi pfarwsi requested a review from nordicjm March 5, 2024 17:06
@kanakshilledar kanakshilledar force-pushed the add_starfive_visionfive2 branch 2 times, most recently from f85d066 to 2189130 Compare March 5, 2024 17:53
@kanakshilledar kanakshilledar force-pushed the add_starfive_visionfive2 branch 2 times, most recently from 2849c7e to 9efaae8 Compare March 6, 2024 02:55
Copy link
Collaborator

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit 3:

  • title and body should just mention the introduction of a new board
  • CODEOWNERS and MAINTAINERS.yml changes should be in another commit (probably the last commit)

commit 4:

  • should be squashed with the commit that introduced the 7110 soc

commit 5:

  • should be squashed with the commit that introduced that yaml file

We generally dont make another commit to just "address maintainers' comments". Rather these requested changes should be made and squashed with the commit that introduced the changes initially where it makes sense.

@kanakshilledar
Copy link
Contributor

@ycsin I have updated the commits according to your suggested changes.

boards/starfive/visionfive2/board.cmake Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
dts/riscv/starfive/jh7110-visionfive-v2.dtsi Outdated Show resolved Hide resolved
dts/riscv/starfive/jh7110-visionfive-v2.dtsi Outdated Show resolved Hide resolved
MAINTAINERS.yml Outdated
Comment on lines 2862 to 2863
- pfarwsi
- kanakshilledar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to agree with @kartben on this one. I've noticed that the usual path people take to be responsible for an area of Zephyr is as follows:

  1. contribute & in general - interact with the community (you're here)
  2. start reviewing other people's code
  3. become a collaborator
  4. become a maintainer

We're of course more than happy to have you and your contributions here. That being said, being responsible for the RISC-V architecture as a whole means you need to have the broader picture, be aware of all the different conventions the project conforms to and so on. And I'm just not sure if that's true for you, having only one PR under your belt.

IMO a smaller area would be better for a new member of the community, i.e. a StarFive-specific one (e.g. see the ITE platforms area) which @ycsin proposed here: https://github.com/zephyrproject-rtos/zephyr/pull/69814/files#r1514001131.

I'm unresolving this thread for now, as this IMO needs more discussion.

@pfarwsi pfarwsi force-pushed the add_starfive_visionfive2 branch 2 times, most recently from dad9d71 to 3ba0ae5 Compare March 8, 2024 09:05
MAINTAINERS.yml Outdated Show resolved Hide resolved
These list of files add basic support for StarFive
JH7110 SOC Device Tree includes for VisionFive2
board.

Signed-off-by: Pratik Farkase <pratik.farkase@wsisweden.com>
These list of files add Kconfig support for
Starfive JH7110 SOC support.

Signed-off-by: Pratik Farkase <pratik.farkase@wsisweden.com>
these list of patches add support the Starfive Visionfive2
SBC based on the JH7110 SoC. Board identifier is `visionfive2`.

Signed-off-by: Kanak Shilledar <kanakshilledar111@protonmail.com>
Signed-off-by: Pratik Farkase <pratik.farkase@wsisweden.com>
@pfarwsi pfarwsi force-pushed the add_starfive_visionfive2 branch 2 times, most recently from 6cbbbcf to 6c19987 Compare March 8, 2024 09:19
cfriedt
cfriedt previously approved these changes Mar 8, 2024
Copy link
Collaborator

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last commit title and body should be updated

@kanakshilledar
Copy link
Contributor

@ycsin I have incorporated the suggested changes in the last commit message title and body

@pfarwsi pfarwsi requested a review from ycsin March 11, 2024 09:56
Copy link
Member

@fkokosinski fkokosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit, LGTM otherwise.

MAINTAINERS.yml Outdated Show resolved Hide resolved
added files for VisionFive 2 board and JH7110 SoC under the
RISCV Arch area.

Signed-off-by: Kanak Shilledar <kanakshilledar111@protonmail.com>
@dleach02 dleach02 merged commit 24a1280 into zephyrproject-rtos:main Mar 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Process area: RISCV RISCV Architecture (32-bit & 64-bit)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants