posix: sysconf: add a "small" implementation option #69882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
full-sysconf
branch
4 times, most recently
from
0a8222d
to
a366d42
Compare
16 tasks
|
Was hoping to tag @awojasinski for review here as well. |
cfriedt
changed the title
ycsin
previously approved these changes
Mar 11, 2024
include/zephyr/posix/unistd.h
Outdated
| @@ -99,6 +99,7 @@ extern "C" { | |||
| #define _POSIX2_C_BIND _POSIX_VERSION | |||
| #define _POSIX2_C_DEV (-1L) | |||
| #define _POSIX2_CHAR_TERM (-1L) | |||
| #define _POSIX2_DELAYTIMER_MAX (-1L) | |||
There was a problem hiding this comment.
Suggested change
| #define _POSIX2_DELAYTIMER_MAX (-1L) | |
| #define _POSIX2_DELAYTIMER_MAX (-1L) |
Previously, sysconf() was only available as a macro (i.e. the "extra-small" option). This has the advantage of being compile-time constant, and optimized for both space and speed. One disadvantage is that querying an `_SC_` value that was invalid or unsupported would result in a compile error. Provide a "small" implementation of sysconf() (via Kconfig choice) as a normal addressable function. Signed-off-by: Christopher Friedt <cfriedt@meta.com>
cfriedt
commented
Mar 11, 2024
ycsin
approved these changes
Mar 12, 2024
jukkar
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
sysconf()was only available as a macro (i.e. the "extra-small" option).That has the advantage of being compile-time constant, optimized for both space and speed. One disadvantage is that a querying an
_SC_value that was invalid or unsupported would result in a compile error.Provide a "small" implementation of
sysconf()(via Kconfig choice) as a normal addressable function.See also #56670