Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial support NXP MCXN947 #69890

Merged
merged 14 commits into from Mar 13, 2024
Merged

Add initial support NXP MCXN947 #69890

merged 14 commits into from Mar 13, 2024

Conversation

mmahadevan108
Copy link
Collaborator

This PR adds initial support for UART console and GPIO for NXP MCXN947.

@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: UART Universal Asynchronous Receiver-Transmitter area: Clock Control platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP area: Pinctrl area: GPIO labels Mar 7, 2024
@zephyrbot
Copy link
Collaborator

zephyrbot commented Mar 7, 2024 •
edited

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@259bc15 zephyrproject-rtos/hal_nxp@3c4f74b (master) zephyrproject-rtos/hal_nxp@259bc153..3c4f74b4

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Mar 7, 2024
nordicjm
nordicjm requested changes Mar 7, 2024
View reviewed changes
boards/nxp/frdm_mcxn947/board.cmake Outdated Show resolved Hide resolved
soc/nxp/mcx/nx4x/Kconfig.soc Outdated Show resolved Hide resolved
danieldegrasse
danieldegrasse reviewed Mar 7, 2024
View reviewed changes
drivers/misc/mcux_lp_flexcomm/mcux_lp_flexcomm.h Outdated Show resolved Hide resolved
drivers/serial/uart_mcux_lpuart.c Outdated Show resolved Hide resolved
drivers/serial/uart_mcux_lpuart.c Outdated Show resolved Hide resolved
soc/nxp/mcx/mcxnx4x/linker.ld Outdated Show resolved Hide resolved
soc/nxp/mcx/mcxnx4x/Kconfig.soc Outdated Show resolved Hide resolved
soc/nxp/mcx/mcxnx4x/soc.c Outdated Show resolved Hide resolved
decsny
decsny requested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@decsny decsny left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not all of the comments are blocking

blocking requested changes in this latest review:

  • copyrights
  • mfd instead of misc
  • log level configurability

drivers/clock_control/clock_control_mcux_syscon.c Outdated Show resolved Hide resolved
drivers/gpio/gpio_mcux.c Outdated Show resolved Hide resolved
drivers/clock_control/clock_control_mcux_syscon.c Show resolved Hide resolved
drivers/misc/CMakeLists.txt Outdated Show resolved Hide resolved
drivers/serial/uart_mcux_lpuart.c Outdated Show resolved Hide resolved
drivers/misc/nxp_lp_flexcomm/nxp_lp_flexcomm.c Outdated Show resolved Hide resolved
drivers/misc/nxp_lp_flexcomm/nxp_lp_flexcomm.c Outdated Show resolved Hide resolved
drivers/misc/nxp_lp_flexcomm/nxp_lp_flexcomm.c Outdated Show resolved Hide resolved
drivers/misc/nxp_lp_flexcomm/nxp_lp_flexcomm.c Outdated Show resolved Hide resolved
drivers/misc/nxp_lp_flexcomm/nxp_lp_flexcomm.c Outdated Show resolved Hide resolved
decsny
decsny previously approved these changes Mar 13, 2024
View reviewed changes
mmahadevan108 and others added 14 commits March 13, 2024 11:55
@mmahadevan108
dts: nxp: Add binding for NXP Flexcomm device
af4eaf4 
This binding is for the NXP FlexComm Interface. The
driver will setup an interface for use as a UART, SPI
or I2C device.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
drivers: mfd: Add NXP LP Flexcomm driver
facc70b 
1. This driver allows to configure the Low Power Flexcomm
   interface as a UART, SPI or I2C device.
2. Manages the interrupts and dispatches it to the
   appropriate device driver.
3. A Flexcomm interface can be configured to be used as
   I2C and UART device. However a SPI device cannot be used
   concurrently with I2C or UART. Add checks for this feature.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
drivers: uart: Use the NXP Flexcomm driver to interrupt handling
6d40b1c 
The Low Power Flexcomm driver manages the interrupt handling
and provides an API to register interrupt callbacks.
Register the NXP LPUART interrupt handler.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
drivers: clock: Enable PORT & LP Flexcomm in NXP syscon driver
47b2147 
1. Add support to enable PORT control clocks
2. Add support for LP Flexcomm
3. MCX family has a different Clock API for USDHC.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
dts: nxp_lpuart: Interrupts is no longer a required property
f03bfb6 
Some NXP SoC's have a FlexComm interface which manages
interrupts.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
drivers: uart: Use the register define instead of enum define
c465fe7 
The enum define is not implemented with the same name on all SoC's.
Use the register define instead.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
dts: pinctrl: Add input buffer for kinetis pinctrl
8e6be57 
Some versions that use the kinetis pinctrl use the
input buffer

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
drivers: pinctrl: Add support for more ports
e3e1af1 
MCX has more port modules which requires updating
the pinctrl driver

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@decsny @mmahadevan108
drivers: gpio_mcux: Add support for GPIO ICR
a5e39bb 
Add support for devices that use the kinetis
GPIO/PORT scheme but with the slight modification
that the interrupt control bits are in the GPIO
peripheral instead of the PORT peripheral.

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
@mmahadevan108
dts: mcxn94x: Add initial support for NXP MCXN94X
a70c506 
Add initial support for NXP MCXN94X

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
soc: mcxn947: Add support for NXP MCXN947
c1c90c5 
Add initial support for NXP MCXN947 SoC

Signed-off-by: Emilio Benavente <emilio.benavente@nxp.com>
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
boards: frdm_mcxn947: Add support for frdm_mcxn947 board
61dcbe0 
Add support for frdm_mcxn947 board

Signed-off-by: Emilio Benavente <emilio.benavente@nxp.com>`
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
west.yml: Get changes for MCXN947 support
7798e07 
Get HAL updates for MCXN947 support

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
doc: frdm_mcxn947: Add documentation for FRDM-MCXN947
7c9a598 
Add documentation for FRDM-MCXN947

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Mar 13, 2024
@fabiobaltieri fabiobaltieri merged commit 870806c into zephyrproject-rtos:main Mar 13, 2024
23 of 24 checks passed
@mmahadevan108 mmahadevan108 deleted the Add_Support_MCXN947 branch March 14, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dleach02 dleach02 dleach02 approved these changes

@danieldegrasse danieldegrasse danieldegrasse approved these changes

@decsny decsny decsny approved these changes

@dbaluta dbaluta Awaiting requested review from dbaluta

@dcpleung dcpleung Awaiting requested review from dcpleung

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@galak galak Awaiting requested review from galak

@gmarull gmarull Awaiting requested review from gmarull

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@manuargue manuargue Awaiting requested review from manuargue

@mnkp mnkp Awaiting requested review from mnkp

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@yvanderv yvanderv Awaiting requested review from yvanderv

@nordicjm nordicjm Awaiting requested review from nordicjm

Assignees

@dleach02 dleach02

Labels
area: Clock Control area: Devicetree Binding PR modifies or adds a Device Tree binding area: GPIO area: MFD area: Pinctrl area: Process area: UART Universal Asynchronous Receiver-Transmitter manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mmahadevan108 @zephyrbot @dleach02 @danieldegrasse @nordicjm @decsny @fabiobaltieri