Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: shields: Add Seeed Studio XIAO Expansion Board #69999

Merged
merged 1 commit into from Mar 25, 2024
Merged

boards: shields: Add Seeed Studio XIAO Expansion Board #69999

merged 1 commit into from Mar 25, 2024
+173 −0

Conversation

CharlesDias
Copy link
Contributor

Add Seeed Studio XIAO Expansion Board:

  • User button
  • SSD1306 128x64 pixels
  • MicroSD
  • PFC8563 RTC

@zephyrbot zephyrbot added the area: Shields Shields (add-on boards) label Mar 9, 2024
kartben
kartben requested changes Mar 9, 2024
View reviewed changes
boards/shields/seeed_xiao_expansion_board/doc/index.rst Outdated
@@ -0,0 +1,84 @@
.. _seeed_xiao_expansion_board:

Seed Studio XIAO Expansion Board
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs s/Seed/Seeed/ in the entire changeset

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

boards/shields/seeed_xiao_expansion_board/doc/index.rst Outdated
for `Seeed Studio XIAO series`_ of only half Raspberry Pi 4 size. It enables
building prototypes and projects in an easy and quick way. With its rich
peripherals, you could explore the infinite possibilities of Seeed Studio
XIAO series. Circuit python is also well supported by this board.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
XIAO series. Circuit python is also well supported by this board.
XIAO series.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for your review!

@CharlesDias CharlesDias force-pushed the seeed_studio_xiao_expans_board branch 2 times, most recently from 1b00987 to 2cd2d22 Compare March 14, 2024 12:46
@CharlesDias
Copy link
Contributor Author

Reduced image size.

@kartben
Copy link
Collaborator

kartben commented Mar 15, 2024

Reduced image size.

Thanks! I just pushed a fixup commit where the image is now transparent, which is even better IMO
also removed the pins diagram as I don't think it adds a lot of value vs. people going to Seeed Studio wiki/website if they need more info.

If that works for you, I'll let you squash the fixup commit :)

kartben
kartben approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool!

@kartben kartben force-pushed the seeed_studio_xiao_expans_board branch from 4c864ab to c79ed49 Compare March 15, 2024 09:54
@CharlesDias
Copy link
Contributor Author

Thanks! I just pushed a fixup commit where the image is now transparent, which is even better IMO also removed the pins diagram as I don't think it adds a lot of value vs. people going to Seeed Studio wiki/website if they need more info.

If that works for you, I'll let you squash the fixup commit :)

Thanks, @kartben! It's perfect for me. Just one question. Now I have to squash the fixup commit and push force? Thanks

@kartben
Copy link
Collaborator

kartben commented Mar 15, 2024

Thanks! I just pushed a fixup commit where the image is now transparent, which is even better IMO also removed the pins diagram as I don't think it adds a lot of value vs. people going to Seeed Studio wiki/website if they need more info.
If that works for you, I'll let you squash the fixup commit :)

Thanks, @kartben! It's perfect for me. Just one question. Now I have to squash the fixup commit and push force? Thanks

Yes!

@CharlesDias
boards: shields: Add Seeed Studio XIAO Expansion Board
0358d94 
Add Seeed Studio XIAO Expansion Board:
- User button
- SSD1306 128x64 pixels
- MicroSD
- PFC8563 RTC

Signed-off-by: Charles Dias <charlesdias.cd@outlook.com>
@CharlesDias CharlesDias force-pushed the seeed_studio_xiao_expans_board branch from c79ed49 to 0358d94 Compare March 17, 2024 11:43
@CharlesDias
Copy link
Contributor Author

Update, @kartben. Thank you for your help!

@CharlesDias
Copy link
Contributor Author

Dear @erwango, @avisconti, and @jfischer-no, could you help with this PR? Thank you.

@aescolar aescolar merged commit a0d7592 into zephyrproject-rtos:main Mar 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@erwango erwango erwango approved these changes

@avisconti avisconti Awaiting requested review from avisconti

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

Assignees

@erwango erwango

Labels
area: Shields Shields (add-on boards)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CharlesDias @kartben @erwango @zephyrbot @aescolar