Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: st: st25dv_mb1283_disco: add mb1283 board #70010

Merged
merged 1 commit into from Mar 13, 2024
Merged

boards: st: st25dv_mb1283_disco: add mb1283 board #70010

merged 1 commit into from Mar 13, 2024

Conversation

everedero
Copy link
Contributor

ST25DV discovery kit, including an LCD color screen. ST25DV support not included.

@ajarmouni-st ajarmouni-st self-requested a review March 11, 2024 10:25
erwango
erwango requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, thanks!

boards/st/st25dv_mb1283_disco/Kconfig.st25dv_mb1283_disco Outdated
# SPDX-License-Identifier: Apache-2.0

config BOARD_ST25DV_MB1283_DISCO
bool "ST25DV discovery board with MB1283"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove bool "...."

@ajarmouni-st
Copy link
Collaborator

Hi @everedero, can you please test samples/modules/lvgl/demos & samples/drivers/display as well, if you haven't already, & confirm that they work correctly? Thanks!

@everedero everedero force-pushed the mb1253 branch 2 times, most recently from 2514764 to 6fd281a Compare March 11, 2024 15:22
@everedero
Copy link
Contributor Author

  • samples/drivers/display work out of the box without any overlay, should I add a configuration file or something?

  • I added overlay and conf files to lvgl samples, music player works despite being very slow.

  • Also, I will open a ticket because the "zephyr,lvgl-keypad-input" driver makes the lvgl sample compilation fail. In the meantime, I will leave it out of the overlay file in lvgl samples, if that's OK with you - afaik these samples do not use lvgl-keypad-input.

erwango
erwango previously approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but ideally you should split boards and samples changes in 2 separate commits.

@ajarmouni-st
Copy link
Collaborator

should I add a configuration file or something?

No.

I added overlay and conf files to lvgl samples, music player works despite being very slow.

Great, thanks!

will leave it out of the overlay file in lvgl samples, if that's OK with you

Yes no problem

ajarmouni-st
ajarmouni-st previously approved these changes Mar 11, 2024
View reviewed changes
kartben
kartben requested changes Mar 12, 2024
View reviewed changes
boards/st/st25dv_mb1283_disco/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/st/st25dv_mb1283_disco/docs/index.rst Outdated Show resolved Hide resolved
boards/st/st25dv_mb1283_disco/docs/index.rst Outdated Show resolved Hide resolved
@everedero
boards: st: st25dv_mb1283_disco: add mb1283 board
c8f525c 
ST25DV discovery kit, including an LCD color screen.
ST25 support not included.

Signed-off-by: Eve Redero <eve.redero@gmail.com>
@everedero everedero dismissed stale reviews from ajarmouni-st and erwango via c8f525c March 12, 2024 19:38
@fabiobaltieri fabiobaltieri assigned erwango and unassigned kartben Mar 13, 2024
@MaureenHelm MaureenHelm merged commit 4809491 into zephyrproject-rtos:main Mar 13, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@GeorgeCGV GeorgeCGV GeorgeCGV approved these changes

@erwango erwango erwango approved these changes

@ajarmouni-st ajarmouni-st ajarmouni-st left review comments

@ABOSTM ABOSTM Awaiting requested review from ABOSTM

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@Desvauxm-st Desvauxm-st Awaiting requested review from Desvauxm-st

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@nashif nashif Awaiting requested review from nashif

Assignees

@erwango erwango

Labels
area: Display area: Samples Samples platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@everedero @ajarmouni-st @kartben @GeorgeCGV @erwango @MaureenHelm @zephyrbot