boards: nuvoton: add support for numaker m2l31ki #70357

cyliangtw · 2024-03-18T08:38:48Z

This PR is to add the new development board numaker_m2l31ki for m2l31x series.

It's verified on NuMaker-M2L31KI EVB by the test code of blinky, hello_world, gpio_basic_api & flash/common.

nordicjm · 2024-03-18T08:40:02Z

boards/nuvoton/numaker_m2l31ki/Kconfig.defconfig

+if BOARD_NUMAKER_M2L31KI
+
+endif # BOARD_NUMAKER_M2L31KI


delete file

Thanks of your advice, I deleted this redundant file.

nordicjm · 2024-03-18T08:40:24Z

boards/nuvoton/numaker_m2l31ki/doc/m2l31ki.jpg

Make this a webp and use https://tinypng.com/

Yes, it already made by this tool to save 13% ~ 14%.

The 1st commit jpg file was made by this webp, improved file size from 83KB to 72KB.

nordicjm · 2024-03-18T08:40:47Z

boards/nuvoton/numaker_m2l31ki/numaker_m2l31ki.dts

+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		slot0_partition: partition@0 {


How are these slots used if there is no bootloader?

These proposed slots should be used by bootloader.

In \tests\drivers\flash\common\src, it will utilize the
#define TEST_AREA storage_partition.

Application has update client capacity and could download new firmware & write it into slot1 in runtime.
As while bootloader detect new firmware in slot1, it could clone into slot0 and set as active image.

Is this an inbuilt bootloader on the MCU itself? i.e. in mask ROM?

No, it's not the mask ROM.
Slot0 & Slot1 belong to APROM.
The chip has one LDROM ( loader-rom), user could program the loader (i.e small firmware).

My question is do these work out of the box or does someone need to build and load their own bootloader e.g. mcuboot? If this works out of the box then this can be marked as resolved, if they need e.g. mcuboot or another bootloader which they need to flash themselves then there should be a partition here for that bootloader

It need one bootloader, so I add one more partition for loader in numaker_m2l31ki.dts .
Update commit f93489d.

Is slot2 the bootloader? If so, how does that code partition run first? If you are using mcuboot could you copy the naming from here: https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/nordic/nrf52840dk/nrf52840dk_nrf52840.dts#L277

Yes, it could be mucboot or another simple bootloader.
Thanks and it's OK to use the same naming.

boards/nuvoton/numaker_m2l31ki/numaker_m2l31ki.dts

fabiobaltieri · 2024-03-19T12:18:40Z

boards/nuvoton/numaker_m2l31ki/board.cmake

+board_runner_args(nulink "-f")
+
+include(${ZEPHYR_BASE}/boards/common/openocd.board.cmake)
+include(${ZEPHYR_BASE}/boards/common/nulink.board.cmake)


hey just noticed this one:

$ west flash -r nulink -- west flash: using runner nulink FATAL ERROR: unknown runner "nulink"

Are you going to upstream this?

So far, no plan and I remove this proprietary nulink runner.
Thanks & update commit d052b2b

Ok thanks for clarifying, the whole boards/common/nulink.board.cmake should probably go as well then. That said, I think it should be acceptable to keep it as long as you contribute the west runner script as well (the file in scripts/west_commands/runners, even if the binary it self is not distributed with the project. At least that's how nrfutil and nrfjprog works already (and probably more).

nordicjm · 2024-03-20T10:05:45Z

boards/nuvoton/numaker_m2l31ki/doc/m2l31ki.jpg

Make smaller. e.g. cwebp -q 80 m2l31ki.jpg -o m2l31ki.webp gives a file 58% of the file size here without changing resolution

The size improvement is excellent, I changed to m2l31ki.webp .

nordicjm · 2024-03-20T10:07:02Z

boards/nuvoton/numaker_m2l31ki/numaker_m2l31ki.dts

+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		slot0_partition: partition@0 {


My question is do these work out of the box or does someone need to build and load their own bootloader e.g. mcuboot? If this works out of the box then this can be marked as resolved, if they need e.g. mcuboot or another bootloader which they need to flash themselves then there should be a partition here for that bootloader

fabiobaltieri · 2024-03-20T14:57:04Z

boards/nuvoton/numaker_m2l31ki/doc/index.rst

+specially developed by Nuvoton. The NuMaker-M2L31KI is based on the NuMicro® M2L31
+series MCU with ARM® -Cortex®-M23 core.
+
+.. image:: ./m2l31ki.jpg


/home/runner/_work/zephyr/zephyr/doc/_build/src/boards/nuvoton/numaker_m2l31ki/doc/index.rst:: WARNING: image file not readable: ../../../boards/nuvoton/numaker_m2l31ki/doc/m2l31ki.jpg

webp?

Yes, it's webp. Sorry forget to modify index.rst

nordicjm · 2024-03-20T14:59:46Z

boards/nuvoton/numaker_m2l31ki/numaker_m2l31ki.dts

+		slot0_partition: partition@8000 {
+			label = "image-0";
+			reg = <0x00008000 0x00038000>;
+		};
+		slot1_partition: partition@40000 {
+			label = "image-1";
+			reg = <0x00040000 0x0003e000>;
+		};


This will not work for MCUboot, the sizes depend upon what operating mode you are going to use:

swap using move: images can be same size but this is inefficient, slot0 should be larger than slot1, the most efficient size can be determined by building e.g. samples/subsys/mgmt/mcumgr/smp_svr for your board using sysbuild, ensuring the the MCUboot image has logging enabled and set to debug level, then when booting checking the message that will be printed on the board that mentions about slot sizes.

overwrite only: images must be same size

XIP: images must be same size

Thanks your advice, I will adjust to fulfill overwrite only by tomorrow.

Updated to let image 0 & image 1 same size.

Add new development board numaker_m2l31ki for m2l31x series. Signed-off-by: cyliang tw <cyliang@nuvoton.com>

zephyrbot added the platform: Nuvoton Numicro Numaker Nuvoton Technology Corporation, Numicro Numaker label Mar 18, 2024

zephyrbot requested a review from ssekar15 March 18, 2024 08:39

zephyrbot assigned cyliangtw Mar 18, 2024

nordicjm requested changes Mar 18, 2024

View reviewed changes

cyliangtw force-pushed the nvt_m2l31_board branch from a1b7134 to e7ac825 Compare March 18, 2024 08:58

cyliangtw requested a review from fabiobaltieri March 19, 2024 01:46

fabiobaltieri reviewed Mar 19, 2024

View reviewed changes

cyliangtw force-pushed the nvt_m2l31_board branch 2 times, most recently from 48edae5 to d052b2b Compare March 20, 2024 08:09

cyliangtw requested a review from nordicjm March 20, 2024 09:47

nordicjm reviewed Mar 20, 2024

View reviewed changes

cyliangtw force-pushed the nvt_m2l31_board branch 3 times, most recently from c343213 to 701dbf9 Compare March 20, 2024 12:32

fabiobaltieri previously approved these changes Mar 20, 2024

View reviewed changes

fabiobaltieri reviewed Mar 20, 2024

View reviewed changes

nordicjm reviewed Mar 20, 2024

View reviewed changes

boards: nuvoton: add support for numaker m2l31ki

98eef2a

Add new development board numaker_m2l31ki for m2l31x series. Signed-off-by: cyliang tw <cyliang@nuvoton.com>

cyliangtw dismissed fabiobaltieri’s stale review via 98eef2a March 21, 2024 08:08

cyliangtw force-pushed the nvt_m2l31_board branch from 701dbf9 to 98eef2a Compare March 21, 2024 08:08

nordicjm approved these changes Mar 21, 2024

View reviewed changes

fabiobaltieri approved these changes Mar 21, 2024

View reviewed changes

fabiobaltieri merged commit 62665ea into zephyrproject-rtos:main Mar 21, 2024
21 checks passed

carlescufi mentioned this pull request Mar 31, 2024

numaker_m2l31ki is currently broken #70929

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boards: nuvoton: add support for numaker m2l31ki #70357

boards: nuvoton: add support for numaker m2l31ki #70357

cyliangtw commented Mar 18, 2024

nordicjm Mar 18, 2024

cyliangtw Mar 18, 2024

nordicjm Mar 18, 2024

cyliangtw Mar 18, 2024

cyliangtw Mar 19, 2024

nordicjm Mar 18, 2024

cyliangtw Mar 18, 2024

cyliangtw Mar 18, 2024

nordicjm Mar 18, 2024 •

edited

cyliangtw Mar 18, 2024

nordicjm Mar 20, 2024

cyliangtw Mar 20, 2024

nordicjm Mar 20, 2024

cyliangtw Mar 20, 2024

fabiobaltieri Mar 19, 2024

cyliangtw Mar 20, 2024 •

edited

fabiobaltieri Mar 20, 2024

nordicjm Mar 20, 2024

cyliangtw Mar 20, 2024

nordicjm Mar 20, 2024

fabiobaltieri Mar 20, 2024

cyliangtw Mar 20, 2024

cyliangtw Mar 21, 2024

nordicjm Mar 20, 2024

cyliangtw Mar 20, 2024

cyliangtw Mar 21, 2024

boards: nuvoton: add support for numaker m2l31ki #70357

boards: nuvoton: add support for numaker m2l31ki #70357

Conversation

cyliangtw commented Mar 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nordicjm Mar 18, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyliangtw Mar 20, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nordicjm Mar 18, 2024 •

edited

cyliangtw Mar 20, 2024 •

edited