Bluetooth: Audio: Broadcast Assistant: Check add_source duplication #70373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a check for checking duplication when adding a source in the broadcast assistant, as per requirement in BAP 6.5.4. It is not permitted to add a source such that a combination of broadcast_id, adv_sid and address type would result in same triple of values. Added a recv_state struct to cache these values when read, and moved past_avail and srd_ids into this as well. Signed-off-by: Fredrik Danebjer <frdn@demant.com>
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
jhedberg,
kruithofa,
larsgk,
MariuszSkamra,
pin-zephyr,
sjanc and
Thalley
Thalley
reviewed
Mar 25, 2024
Thalley
requested changes
Mar 25, 2024
Thalley
requested changes
Apr 3, 2024
…nction Moved the check of broadcast src duplicate to function while adding source. Signed-off-by: Nithin Ramesh Myliattil <niym@demant.com>
niym-ot
force-pushed
the
assistant_guard_add_src
branch
from
da70472
to
9c6c1d3
Compare
Thalley
approved these changes
Apr 3, 2024
larsgk
approved these changes
Apr 3, 2024
larsgk
added a commit
to larsgk/zephyr
that referenced
this pull request
May 31, 2024
Nithin has contributed the following PRs zephyrproject-rtos#72908 zephyrproject-rtos#72333 zephyrproject-rtos#71798 zephyrproject-rtos#70373 and is attending the weekly LE Audio Zephyr meetings. Signed-off-by: Lars Knudsen <larsgk@gmail.com>
larsgk
added a commit
to larsgk/zephyr
that referenced
this pull request
May 31, 2024
Nithin has contributed the following PRs zephyrproject-rtos#72908 zephyrproject-rtos#72333 zephyrproject-rtos#71798 zephyrproject-rtos#70373 and is attending the weekly LE Audio Zephyr meetings. Signed-off-by: Lars Knudsen <larsgk@gmail.com>
larsgk
added a commit
to larsgk/zephyr
that referenced
this pull request
May 31, 2024
Nithin has contributed the following PRs zephyrproject-rtos#72908 zephyrproject-rtos#72333 zephyrproject-rtos#71798 zephyrproject-rtos#70373 and is attending the weekly LE Audio Zephyr meetings. Signed-off-by: Lars Knudsen <larsgk@gmail.com>
henrikbrixandersen
pushed a commit
that referenced
this pull request
Jun 1, 2024
coreboot-org-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this pull request
Jun 4, 2024
Nithin has contributed the following PRs zephyrproject-rtos/zephyr#72908 zephyrproject-rtos/zephyr#72333 zephyrproject-rtos/zephyr#71798 zephyrproject-rtos/zephyr#70373 and is attending the weekly LE Audio Zephyr meetings. (cherry picked from commit 3fd01c5) Original-Signed-off-by: Lars Knudsen <larsgk@gmail.com> GitOrigin-RevId: 3fd01c5 Change-Id: I1539d7f9acb7d333ae6c6200dffaec5deceb0c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5591121 Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
crazyskady
pushed a commit
to crazyskady/zephyr
that referenced
this pull request
Jun 6, 2024
Nithin has contributed the following PRs zephyrproject-rtos#72908 zephyrproject-rtos#72333 zephyrproject-rtos#71798 zephyrproject-rtos#70373 and is attending the weekly LE Audio Zephyr meetings. Signed-off-by: Lars Knudsen <larsgk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check for checking duplication when adding a source in the broadcast assistant, as per requirement in BAP 6.5.4. It is not permitted to add a source such that a combination of broadcast_id, adv_sid and address type would result in same triple of values. Added a recv_state struct to cache these values when read, and moved past_avail and srd_ids into this as well.
Since there is no application specific error code present today, the assistant would not know if an add_src failed due to duplication, and so this has not been added to this PR. We should get an errata fix for this first.
This partially fixes #69661