posix: rwlock: implement pthread_rwlockattr_setpshared() #70421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
rwlockattr-pshared
branch
from
0f27eaf
to
f4fed00
Compare
jukkar
reviewed
Mar 19, 2024
cfriedt
force-pushed
the
rwlockattr-pshared
branch
from
84cff27
to
aadd0a9
Compare
@jukkar - can you please re-approve |
cfriedt
force-pushed
the
rwlockattr-pshared
branch
3 times, most recently
from
9dfd418
to
2cdb008
Compare
Move the implementation of the following functions into the posix library rather than having themn as static inline functions. * pthread_rwlockattr_init() * pthread_rwlockattr_destroy() Signed-off-by: Christopher Friedt <cfriedt@meta.com>
Implement pthread_rwlockattr_setpshared() and pthread_rwlockattr_getpshared(). Both functions are required by the _POSIX_READER_WRITER_LOCKS Option as detailed in Section E.1 of IEEE-1003.1-2017. The _POSIX_READER_WRITER_LOCKS Option is required for PSE51, PSE52, PSE53, and PSE54 conformance, and is otherwise mandatory for any POSIX conforming system as per Section A.2.1.3 of IEEE-1003-1.2017. Signed-off-by: Christopher Friedt <cfriedt@meta.com>
Add tests for pthread_rwlockattr_setpshared() and pthread_rwlockattr_getpshared(). Signed-off-by: Christopher Friedt <cfriedt@meta.com>
Mark pthread_rwlockattr_setpshared() and pthread_rwlockattr_getpshared() as supported in the POSIX Options documentation. Signed-off-by: Christopher Friedt <cfriedt@meta.com>
cfriedt
force-pushed
the
rwlockattr-pshared
branch
from
2cdb008
to
b352f2c
Compare
jukkar
approved these changes
Mar 22, 2024
ycsin
approved these changes
Mar 22, 2024
|
It looks like the 2d review period is up for this too. |
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
pthread_rwlockattr_setpshared()andpthread_rwlockattr_getpshared().Both functions are required by the
_POSIX_READER_WRITER_LOCKSOption as detailed in Section E.1 of IEEE-1003.1-2017.The
_POSIX_READER_WRITER_LOCKSOption is required for PSE51, PSE52, PSE53, and PSE54 conformance, and is otherwise mandatory for any POSIX conforming system as per Section A.2.1.3 of IEEE-1003-1.2017.Fixes #66964
Fixes #66965