Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: nxp: Add GAU drivers for DAC and ADC #70506

Merged
merged 8 commits into from
May 14, 2024

Conversation

decsny
Copy link
Member

@decsny decsny commented Mar 20, 2024

Add driver for DAC and ADC present on RW SOCs which are part of the GAU (General Analog Unit) module

@zephyrbot zephyrbot added area: Samples Samples area: ADC Analog-to-Digital Converter (ADC) area: DAC Digital-to-Analog Converter platform: NXP NXP area: Devicetree Binding PR modifies or adds a Device Tree binding platform: NXP Drivers NXP Semiconductors, drivers labels Mar 20, 2024
@zephyrbot
Copy link
Collaborator

zephyrbot commented Mar 20, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Mar 20, 2024
@dleach02
Copy link
Member

update west manifiest and address merge conflicts

@zephyrbot zephyrbot removed manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Mar 25, 2024
@decsny decsny marked this pull request as draft March 25, 2024 14:20
Copy link
Member

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DAC looks good to me. Only found a small typo.

drivers/dac/Kconfig.mcux Outdated Show resolved Hide resolved
@DerekSnell DerekSnell removed their request for review April 29, 2024 12:35
@decsny
Copy link
Member Author

decsny commented Apr 29, 2024

@sylvioalves there is some esp32 dev kit failing ci on this PR, can you check about it, I think it's unrelated

@sylvioalves
Copy link
Collaborator

sylvioalves commented Apr 29, 2024

@sylvioalves there is some esp32 dev kit failing ci on this PR, can you check about it, I think it's unrelated

/zephyr/zephyr/tests/drivers/adc/adc_api/src/test_adc.c:45:2: error: #error "Unsupported board." We can fix it.

Edit: Fix: #72122

danieldegrasse
danieldegrasse previously approved these changes Apr 30, 2024
martinjaeger
martinjaeger previously approved these changes May 1, 2024
@decsny
Copy link
Member Author

decsny commented May 1, 2024

@anangl please help review

@decsny decsny added the dev-review To be discussed in dev-review meeting label May 14, 2024
@decsny
Copy link
Member Author

decsny commented May 14, 2024

added dev review because assignee/maintainer not responsive

anangl
anangl previously approved these changes May 14, 2024
return 0;
};

struct dac_driver_api nxp_gau_dac_driver_api = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not static const?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a mistake, I'll fix it

Add binding for NXP GAU DAC

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add binding for NXP GAU ADC

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add driver for NXP GAU ADC using MCUX HAL.

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add driver for NXP GAU DAC using MCUX HAL.

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add DT node entries to RW for DAC and ADC.

Support the SOC required initialization of the DAC and ADC on RW.

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Enable the GAU analog converters on the RD_RW612_BGA board.

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Enable RW612 RD board to test ADC

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Enable RW612 RD board for the DAC sample

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
@decsny decsny dismissed stale reviews from anangl, martinjaeger, and danieldegrasse via 7a4f887 May 14, 2024 15:50
@decsny decsny removed the dev-review To be discussed in dev-review meeting label May 14, 2024
@nashif nashif merged commit 595ee90 into zephyrproject-rtos:main May 14, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ADC Analog-to-Digital Converter (ADC) area: DAC Digital-to-Analog Converter area: Devicetree Binding PR modifies or adds a Device Tree binding area: Samples Samples platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants