Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: Host: Add a validation for hci_le_read_max_data_len() #70521

Merged
merged 1 commit into from Mar 26, 2024

Conversation

swkim101
Copy link
Contributor

Check and warn if max_tx_octects and max_tx_time exceed their valid ranges, according to the BT Core spec 5.4 [Vol 4, Part E, 7.8.46].

Fix #70472

Copy link

Hello @swkim101, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

alwa-nordic
alwa-nordic previously approved these changes Mar 22, 2024
jhedberg
jhedberg previously approved these changes Mar 22, 2024
Thalley
Thalley previously approved these changes Mar 25, 2024
subsys/bluetooth/host/hci_core.c Outdated Show resolved Hide resolved
Check max_tx_octects and max_tx_time are in the valid range, according
to the BT Core spec 5.4 [Vol 4, Part E, 7.8.46]
Fix #70472

Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>
@fabiobaltieri fabiobaltieri merged commit 2ca179c into zephyrproject-rtos:main Mar 26, 2024
24 checks passed
Copy link

Hi @swkim101!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bluetooth: hci_le_read_max_data_len() lacks a validation
7 participants