-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bluetooth: nus: Change Kconfigs prefix to BT_ZEPHYR_NUS #70698
Merged
jhedberg
merged 1 commit into
zephyrproject-rtos:main
from
ubieda:fix/bt-nus-kconfigs-conflicting-with-ncs
Apr 2, 2024
Merged
bluetooth: nus: Change Kconfigs prefix to BT_ZEPHYR_NUS #70698
jhedberg
merged 1 commit into
zephyrproject-rtos:main
from
ubieda:fix/bt-nus-kconfigs-conflicting-with-ncs
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth Host
area: Bluetooth
area: Linker Scripts
area: Samples
Samples
area: Logging
area: Build System
Release Notes
To be mentioned in the release notes
area: Shell
Shell subsystem
area: UART
Universal Asynchronous Receiver-Transmitter
labels
Mar 25, 2024
zephyrbot
requested review from
57300,
alwa-nordic,
asbjornsabo,
hermabe,
jeremybettis,
jhedberg,
jori-nordic,
kartben,
nashif,
nordicjm,
sjanc,
tejlmand,
Thalley,
theob-pro and
Vudentz
March 25, 2024 21:25
FYI - @carlescufi @jori-nordic @alwa-nordic |
jori-nordic
previously approved these changes
Mar 26, 2024
Thalley
reviewed
Mar 26, 2024
alwa-nordic
previously approved these changes
Mar 26, 2024
nordicjm
previously approved these changes
Mar 26, 2024
To prevent future conflicts with NCS's NUS implementation, whose Kconfig's are prefixed with BT_NUS. Signed-off-by: Luis Ubieda <luisf@croxel.com>
ubieda
dismissed stale reviews from nordicjm, alwa-nordic, and jori-nordic
via
March 26, 2024 14:40
936ea5e
ubieda
force-pushed
the
fix/bt-nus-kconfigs-conflicting-with-ncs
branch
from
March 26, 2024 14:40
b720715
to
936ea5e
Compare
ubieda
changed the title
bluetooth: nus: Change Kconfigs prefix to BT_NUS_ZEPHYR
bluetooth: nus: Change Kconfigs prefix to BT_ZEPHYR_NUS
Mar 26, 2024
jhedberg
approved these changes
Mar 26, 2024
alwa-nordic
approved these changes
Mar 26, 2024
jori-nordic
approved these changes
Mar 26, 2024
Thalley
approved these changes
Mar 26, 2024
kartben
approved these changes
Mar 26, 2024
carlescufi
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
carlescufi
requested review from
gmarull
and removed request for
Vudentz,
asbjornsabo,
jeremybettis and
57300
March 29, 2024 15:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Bluetooth Host
area: Bluetooth
area: Build System
area: Linker Scripts
area: Logging
area: Samples
Samples
area: Shell
Shell subsystem
area: UART
Universal Asynchronous Receiver-Transmitter
Release Notes
To be mentioned in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent future conflicts with NCS's NUS implementation, whose Kconfig's are prefixed with BT_NUS.
This is a follow-up to PR #69881.