Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: nus: Change Kconfigs prefix to BT_ZEPHYR_NUS #70698

Conversation

ubieda
Copy link
Collaborator

@ubieda ubieda commented Mar 25, 2024

To prevent future conflicts with NCS's NUS implementation, whose Kconfig's are prefixed with BT_NUS.

This is a follow-up to PR #69881.

@ubieda
Copy link
Collaborator Author

ubieda commented Mar 25, 2024

FYI - @carlescufi @jori-nordic @alwa-nordic
I failed to see this during initial development. It's not a problem at the moment but it might when NCS eventually catches up to a recent Zephyr version.

jori-nordic
jori-nordic previously approved these changes Mar 26, 2024
drivers/serial/Kconfig.bt Outdated Show resolved Hide resolved
alwa-nordic
alwa-nordic previously approved these changes Mar 26, 2024
nordicjm
nordicjm previously approved these changes Mar 26, 2024
To prevent future conflicts with NCS's NUS implementation, whose
Kconfig's are prefixed with BT_NUS.

Signed-off-by: Luis Ubieda <luisf@croxel.com>
@ubieda ubieda dismissed stale reviews from nordicjm, alwa-nordic, and jori-nordic via 936ea5e March 26, 2024 14:40
@ubieda ubieda force-pushed the fix/bt-nus-kconfigs-conflicting-with-ncs branch from b720715 to 936ea5e Compare March 26, 2024 14:40
@ubieda ubieda changed the title bluetooth: nus: Change Kconfigs prefix to BT_NUS_ZEPHYR bluetooth: nus: Change Kconfigs prefix to BT_ZEPHYR_NUS Mar 26, 2024
Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@carlescufi carlescufi requested review from gmarull and removed request for Vudentz, asbjornsabo, jeremybettis and 57300 March 29, 2024 15:47
@jhedberg jhedberg merged commit 92e0d0b into zephyrproject-rtos:main Apr 2, 2024
31 checks passed
@ubieda ubieda deleted the fix/bt-nus-kconfigs-conflicting-with-ncs branch May 8, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants